andrzej-kaczmarek commented on code in PR #1682: URL: https://github.com/apache/mynewt-nimble/pull/1682#discussion_r1506716618
########## nimble/host/include/host/ble_cs.h: ########## @@ -0,0 +1,352 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef H_BLE_CS_ +#define H_BLE_CS_ +#include "syscfg/syscfg.h" + +struct ble_cs_rd_loc_supp_cap_rp { Review Comment: functions like that should be just static in ble_cs.c public API should not be wrappers for HCI commands, we should try to hide some parts that are irrelevant for user if possible. at the moment I wouldn't focus too much on that API, just make something that allow to interact with CS and we can think of it later. simply put a comment in ble_cs.h that all APIs in that file are experimental and subject to change at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
