MariuszSkamra commented on code in PR #1675:
URL: https://github.com/apache/mynewt-nimble/pull/1675#discussion_r1508947111


##########
nimble/host/audio/include/audio/ble_audio.h:
##########
@@ -329,6 +536,18 @@ struct ble_audio_event_broadcast_announcement {
     struct ble_audio_broadcast_name *name;
 };
 
+/** @brief Codec Registered */
+struct ble_audio_event_codec_changed {
+    /** Change type */
+    enum {
+        CODEC_REGISTERED,
+        CODEC_UNREGISTERED,
+    } change;
+
+    /** Codec Record */
+    const struct ble_audio_codec_record *record;
+};

Review Comment:
   I'm not sure about this one. IMO it would be cleaner to split this into 2 
events:
   BLE_AUDIO_EVENT_CODEC_REGISTERED
   BLE_AUDIO_EVENT_CODEC_UNREGISTERED



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to