sjanc commented on code in PR #550:
URL: https://github.com/apache/mynewt-newt/pull/550#discussion_r1549381073


##########
newt/downloader/downloader.go:
##########
@@ -451,6 +455,16 @@ func (gd *GenericDownloader) Checkout(repoDir string, 
commit string) error {
        return err
 }
 
+func (gd *GenericDownloader) ApplyPatches(repoDir string, patches []string) 
error {
+       cmd := []string{
+               "am",
+       }
+       cmd = append(cmd, patches...)
+
+       _, err := executeGitCommand(repoDir, cmd, true)

Review Comment:
   hmm should we even try to execute 'git am' if no patches were provided?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to