Repository: incubator-mynewt-newt
Updated Branches:
refs/heads/develop 138a96c89 -> e2546a89a
newt - Don't quote APP/BSP/ARCH defines.
Newt specifies the app, BSP, and arch via -D command line options.
Previously, the macro definitions were quoted, e.g.,
-DBSP_NAME="nrf52dk"
The quotes get included in the C string. These quotes a leftover from
when newt used to invoke the shell to execute external commands. Now
that newt executes commands directly, the quotes no longer get
interpretted away.
Now the above command line argument would look like this:
-DBSP_NAME=nrf52dk
Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/repo
Commit:
http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/commit/e2546a89
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/tree/e2546a89
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/diff/e2546a89
Branch: refs/heads/develop
Commit: e2546a89ac0226bf74d3973a4e616ef12634e6d1
Parents: 138a96c
Author: Christopher Collins <[email protected]>
Authored: Fri Jan 6 18:14:45 2017 -0800
Committer: Christopher Collins <[email protected]>
Committed: Fri Jan 6 18:14:45 2017 -0800
----------------------------------------------------------------------
newt/builder/build.go | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/blob/e2546a89/newt/builder/build.go
----------------------------------------------------------------------
diff --git a/newt/builder/build.go b/newt/builder/build.go
index b41d69d..a2a758f 100644
--- a/newt/builder/build.go
+++ b/newt/builder/build.go
@@ -417,17 +417,17 @@ func (b *Builder) PrepBuild() error {
archName := b.targetBuilder.bspPkg.Arch
bspCi.Cflags = append(bspCi.Cflags,
"-DARCH_"+util.CIdentifier(archName))
- bspCi.Cflags = append(bspCi.Cflags, "-DARCH_NAME=\""+archName+"\"")
+ bspCi.Cflags = append(bspCi.Cflags, "-DARCH_NAME="+archName+"")
if b.appPkg != nil {
appName := filepath.Base(b.appPkg.Name())
bspCi.Cflags = append(bspCi.Cflags,
"-DAPP_"+util.CIdentifier(appName))
- bspCi.Cflags = append(bspCi.Cflags,
"-DAPP_NAME=\""+appName+"\"")
+ bspCi.Cflags = append(bspCi.Cflags, "-DAPP_NAME="+appName+"")
}
bspName := filepath.Base(b.bspPkg.Name())
bspCi.Cflags = append(bspCi.Cflags, "-DBSP_"+util.CIdentifier(bspName))
- bspCi.Cflags = append(bspCi.Cflags, "-DBSP_NAME=\""+bspName+"\"")
+ bspCi.Cflags = append(bspCi.Cflags, "-DBSP_NAME="+bspName+"")
baseCi.AddCompilerInfo(bspCi)
