rymanluk commented on a change in pull request #279: BLE Host - Policy for SM
key overflow
URL:
https://github.com/apache/incubator-mynewt-core/pull/279#discussion_r119286487
##########
File path: net/nimble/host/src/ble_sm.c
##########
@@ -892,6 +895,72 @@ ble_sm_key_dist(struct ble_sm_proc *proc,
}
}
+static int
+ble_sm_chk_store_overflow_once(int is_our_sec, uint16_t conn_handle)
Review comment:
maybe instead of is_our_sec we could provide obj_type?
But actually maybe it would be better to create helper
ble_store_overflow_event(obj_type, event_code, void *event_data) and keep this
function to basically check if there is a sufficient place.
I see that helper could be used at least in three places in this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
