ccollins476ad commented on a change in pull request #293: apps/btshell: add 
bletiny clone that uses new shell
URL: 
https://github.com/apache/incubator-mynewt-core/pull/293#discussion_r121022811
 
 

 ##########
 File path: apps/btshell/src/parse.c
 ##########
 @@ -0,0 +1,611 @@
+/*
 
 Review comment:
   Btw, a lot of this file (parse.c) has been extracted from bletiny into a new 
package: util/parse.  I wouldn't expect it to be part of this pull request, but 
at some point we should think about leveraging that package and removing the 
duplicate code in these apps.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to