This is an automated email from the ASF dual-hosted git repository.
jangho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nemo.git
The following commit(s) were added to refs/heads/master by this push:
new 1122f32 [NEMO-118] Implement Skipping (De)Serialization by
ExecutionProperty (#98)
1122f32 is described below
commit 1122f32090cea8c67bb53077d9e4edc94c6c2adf
Author: Sanha Lee <[email protected]>
AuthorDate: Thu Aug 9 17:45:57 2018 +0900
[NEMO-118] Implement Skipping (De)Serialization by ExecutionProperty (#98)
JIRA: [NEMO-118: Implement Skipping (De)Serialization by
ExecutionProperty](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-118)
**Major changes:**
- Remove `SkipSerDesProperty`.
**Minor changes to note:**
- N/A.
**Tests for the changes:**
- Existing integration tests for large shuffle optimization cover this
change.
**Other comments:**
- The skipping feature is implemented in #50 with `BytesEncoderFactory` and
`BytesDecoderFactory`, but the stale property `SkipSerDesProperty` remained.
This stale property is added to assign a separate stage for the vertex having
`RelayTransform`, but it is naturally divided now because of `ResourceSlot`
property.
resolves
[NEMO-118](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-118)
---
.../executionproperty/SkipSerDesProperty.java | 42 ----------------------
.../reshaping/LargeShuffleRelayReshapingPass.java | 2 --
2 files changed, 44 deletions(-)
diff --git
a/common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/SkipSerDesProperty.java
b/common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/SkipSerDesProperty.java
deleted file mode 100644
index f9668ed..0000000
---
a/common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/SkipSerDesProperty.java
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- * Copyright (C) 2018 Seoul National University
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package edu.snu.nemo.common.ir.vertex.executionproperty;
-
-import edu.snu.nemo.common.ir.executionproperty.VertexExecutionProperty;
-
-/**
- * Attaching this property makes runtime to skip serialization and
deserialization for the vertex input and output.
- * TODO #118: Implement Skipping (De)Serialization by ExecutionProperty
- */
-public final class SkipSerDesProperty extends VertexExecutionProperty<Boolean>
{
-
- private static final SkipSerDesProperty SKIP_SER_DES_PROPERTY = new
SkipSerDesProperty();
-
- /**
- * Constructor.
- */
- private SkipSerDesProperty() {
- super(true);
- }
-
- /**
- * Static method exposing the constructor.
- * @return the execution property.
- */
- public static SkipSerDesProperty of() {
- return SKIP_SER_DES_PROPERTY;
- }
-}
diff --git
a/compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/LargeShuffleRelayReshapingPass.java
b/compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/LargeShuffleRelayReshapingPass.java
index 0e476ff..7abee7e 100644
---
a/compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/LargeShuffleRelayReshapingPass.java
+++
b/compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/LargeShuffleRelayReshapingPass.java
@@ -23,7 +23,6 @@ import
edu.snu.nemo.common.ir.edge.executionproperty.CommunicationPatternPropert
import edu.snu.nemo.common.ir.edge.IREdge;
import edu.snu.nemo.common.ir.vertex.IRVertex;
import edu.snu.nemo.common.ir.vertex.OperatorVertex;
-import edu.snu.nemo.common.ir.vertex.executionproperty.SkipSerDesProperty;
import edu.snu.nemo.common.ir.vertex.transform.RelayTransform;
import java.util.Collections;
@@ -59,7 +58,6 @@ public final class LargeShuffleRelayReshapingPass extends
ReshapingPass {
// Insert a merger vertex having transform that write received
data immediately
// before the vertex receiving shuffled data.
final OperatorVertex iFileMergerVertex = new OperatorVertex(new
RelayTransform());
-
iFileMergerVertex.getExecutionProperties().put(SkipSerDesProperty.of());
builder.addVertex(iFileMergerVertex);
final IREdge newEdgeToMerger = new
IREdge(CommunicationPatternProperty.Value.Shuffle,
