[incubator-nemo] branch master updated: [NEMO-218] Throws exception while processing non-keyed events in CreateViewTransform (#121)

[johnyangk]

This is an automated email from the ASF dual-hosted git repository.

johnyangk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nemo.git


The following commit(s) were added to refs/heads/master by this push:
     new fa75565  [NEMO-218] Throws exception while processing non-keyed events 
in CreateViewTransform (#121)
fa75565 is described below

commit fa75565aa3053407f488b42f3aec62d3226ae361
Author: Taegeon Um <taegeo...@gmail.com>
AuthorDate: Fri Sep 14 21:08:48 2018 +0900

    [NEMO-218] Throws exception while processing non-keyed events in 
CreateViewTransform (#121)
    
    JIRA: [NEMO-218: Throws exception while processing non-keyed events in 
CreateViewTransform](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-218)
    
    **Major changes:**
    - remove `if` clause in `CreateViewTransform`.onData()
    
    **Minor changes to note:**
    -
    
    **Tests for the changes:**
    -
    
    **Other comments:**
    -
    
    Closes #121
---
 .../nemo/compiler/frontend/beam/transform/CreateViewTransform.java  | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
 
b/compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
index d4aa195..cd93296 100644
--- 
a/compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
+++ 
b/compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
@@ -55,10 +55,8 @@ public final class CreateViewTransform<I, O> implements 
Transform<I, O> {
   @Override
   public void onData(final I element) {
     // Since CreateViewTransform takes KV(Void, value), this is okay
-    if (element instanceof KV) {
-      final KV<?, ?> kv = (KV<?, ?>) element;
-      multiView.getDataList().add(kv.getValue());
-    }
+    final KV<?, ?> kv = (KV<?, ?>) element; // It will throw a type cast 
exception if the element is not KV
+    multiView.getDataList().add(kv.getValue());
   }
 
   @Override