[
https://issues.apache.org/jira/browse/NETBEANS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470975#comment-16470975
]
Matthias Bläsing commented on NETBEANS-312:
-------------------------------------------
For css.lib the patch can be removed - it migrates the antlr v3 based parser to
antlr v4. As the primary file of the parser (the grammar file) is currently
missing (fix for that is tracked by NETBEANS-565) the patch is of no use. When
the mentioned issue is resolved, the patch can be taken from history, reapplied
(it is donated) and the resulting antlr v4 parser can be used. For now removing
the patch is more benficial.
For the html.validation module:
validator.patch: I looked through the patch and the reviewer is just wrong.
Everywhere a header is touched, either the full file is added or the whole file
is removed. This can be seen from the change header, where one of the two
mentioned files is "/dev/null". Patch header lines diffing against /dev/null
are full-file removals/additions. As a sample see lines 35-39. These lines say:
The file TestRunner.java is removed completely - the following diff (prefixed
by "-") shows the original content of the file, that is removed.
org.whatff.datatype.patch: this patch does not touch headers.
I'll create a PR for removing the css.lib patch.
> Patch files removing headers
> ----------------------------
>
> Key: NETBEANS-312
> URL: https://issues.apache.org/jira/browse/NETBEANS-312
> Project: NetBeans
> Issue Type: Bug
> Reporter: Geertjan Wielenga
> Priority: Major
> Labels: NETBEANS-9
>
> css.lib/src/org/netbeans/modules/css/lib/antlrv4.patch
> html.validation/external/validator.patch
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
