[
https://issues.apache.org/jira/browse/NETBEANS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated NETBEANS-565:
------------------------------------
Labels: pull-request-available (was: )
> Missing Css3.g file from donation
> ---------------------------------
>
> Key: NETBEANS-565
> URL: https://issues.apache.org/jira/browse/NETBEANS-565
> Project: NetBeans
> Issue Type: Bug
> Components: web - CSS Editor
> Affects Versions: 9.0
> Reporter: Matthias Bläsing
> Assignee: Geertjan Wielenga
> Priority: Major
> Labels: pull-request-available
> Attachments: nb_css_parser.patch
>
>
> While investigating a potential CSS parser error I saw while working with NB9
> and noticed, that one of the most important files is missing:
> css.lib/src/org/netbeans/modules/css/lib/Css3.g
> that file holds an antlr3 grammer for CSS 3. That file was not donated
> and I think the reason is, that the header contains a different
> copyright:
> {noformat}
> // Author : Jim Idle, Temporal Wave LLC.
> // Contact : [email protected]
> // Website : http://www.temporal-wave.com
> // License : ANTLR Free BSD License
> {noformat}
> My investigation showed, that the file is based on:
> [https://github.com/antlr/grammars-v3/blob/master/css21/css21.g]
> or
> [https://github.com/antlr/grammars-v3/raw/master/css21/css21.g]
> the headers and big chunks of the first checkin of Css3.g match.
> I see that oracle might feel uncomfortable/prohibited donating the
> whole file, but what could be donated is a diff between the original
> file from the antlr repository and the current state in netbeans.
> In technical term I suggest, that the patch against the base file is
> donated:
> {noformat}
> # Get basefile
> wget https://github.com/antlr/grammars-v3/raw/master/css21/css21.g
> # Get netbeans state
> wget
> http://hg.netbeans.org/releases/raw-file/tip/css.lib/src/org/netbeans/modules/css/lib/Css3.g
> # Create patch
> diff -u css21.g Css3.g > nb_css_parser.patch
> {noformat}
> That diff than only contains changes done by netbeans committers and this is
> either covered by the normal Oracle copyright (employees working on
> netbeans) or the OCLA.
> Maybe it helps, that there are only three authors listed in the history
> (taken from the releases repository):
> * Marek Fukala <[email protected]>
> * Milutin Kristofic <[email protected]>
> * Ondrej Brejla <[email protected]>
> As requested by mail I created this issue to track the donation. I attached
> the diff/patch described above to this issue. I did not touch the file after
> creating the diff, as the license headers can be adjusted if/when oracle
> agrees to donate the contents (I'm willing to do the integration).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
