[
https://issues.apache.org/jira/browse/NETBEANS-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695159#comment-16695159
]
Laszlo Kishalmi commented on NETBEANS-1719:
-------------------------------------------
It seems the PR worked.
The diff between the PR generated and 10.0-vc3 source package are:
{code:java}
diff -ru netbeans-vc3/nbbuild/build.xml netbeans-vc4/nbbuild/build.xml
--- netbeans-vc3/nbbuild/build.xml 2018-11-05 21:49:08.000000000 -0800
+++ netbeans-vc4/nbbuild/build.xml 2018-11-21 18:20:42.000000000 -0800
@@ -72,8 +72,8 @@
<downloadbinaries cache="${binaries.cache}" server="${binaries.server}">
<manifest dir="${nb_all}">
<include name="nbbuild/external/binaries-list"/>
- <include name="libs.junit4/external/binaries-list"/>
- <include name="javahelp/external/binaries-list"/>
+ <include name="platform/libs.junit4/external/binaries-list"/>
+ <include name="platform/javahelp/external/binaries-list"/>
</manifest>
</downloadbinaries>
@@ -1618,9 +1618,16 @@
</condition>
<zip zipfile="${nb.build.dir}/${cluster.config}-src-${buildnum}.zip"
duplicate="preserve">
<zipfileset dir="${nb_all}" includes="${source.dirs}">
+ <!--exclude all build directories and external jars/zips in the top level
directory:-->
<exclude name="*/build/"/>
<exclude name="*/external/*.jar"/>
<exclude name="*/external/*.zip"/>
+ <!--exclude all build directories and external jars/zips in the cluster
directories,
+ but keep nbi/infra/build, which is a directory with sources:-->
+ <exclude name="[^n]*/*/build/"/>
+ <exclude name="nb/*/build/"/>
+ <exclude name="*/*/external/*.jar"/>
+ <exclude name="*/*/external/*.zip"/>
<exclude name="nbbuild/netbeans/**"/>
<exclude name="nbbuild/cluster.properties" />
</zipfileset>
Only in
netbeans-vc3/platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data:
dummy-signed.jar
Only in
netbeans-vc3/platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data:
dummy-signed-twice.jar
Only in netbeans-vc3/platform/javahelp/external: jhall-2.0_05.jar
Only in netbeans-vc3/platform/libs.junit4/external: hamcrest-core-1.3.jar
Only in netbeans-vc3/platform/libs.junit4/external: junit-4.12.jar
Only in netbeans-vc3/platform/libs.osgi/external: osgi.cmpn-4.2.jar
Only in netbeans-vc3/platform/netbinox/external:
org.eclipse.osgi_3.9.1.v20140110-1610.jar{code}
> Remove JARs in Apache NetBeans 10 vc3
> -------------------------------------
>
> Key: NETBEANS-1719
> URL: https://issues.apache.org/jira/browse/NETBEANS-1719
> Project: NetBeans
> Issue Type: Task
> Reporter: Geertjan Wielenga
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> I don’t think these are OK except perhaps the first one:
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/empty.jar
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/dummy-signed-twice.jar
> ./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/dummy-signed.jar
> And these are certainly not:
> ./platform/libs.junit4/external/junit-4.12.jar
> ./platform/libs.junit4/external/hamcrest-core-1.3.jar
> ./platform/netbinox/external/org.eclipse.osgi_3.9.1.v20140110-1610.jar
> ./platform/libs.osgi/external/osgi.cmpn-4.2.jar
> ./platform/javahelp/external/jhall-2.0_05.jar
> See Justin McLean in IMPC vote thread for Apache NetBeans 10 vc3:
> https://lists.apache.org/thread.html/d127662d8612bf97d982abc1474a6d552704a35075a7d12f111faec4@%3Cgeneral.incubator.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
