[
https://issues.apache.org/jira/browse/NETBEANS-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870616#comment-16870616
]
Jose Pereda edited comment on NETBEANS-2506 at 6/23/19 6:43 PM:
----------------------------------------------------------------
The PR was merged (see
[commit|https://github.com/apache/netbeans/commit/340934ecdbb38c6ceab405a1df99ffa1456e8401]),
NetBeans 11.1-beta1 was tagged after that, but the current released version,
downloaded from
[here|https://builds.apache.org/job/netbeans-release/413/artifact/dist/netbeans-11.1-beta1-bin.zip],
doesn't show the {{OpenJFX}} category when opening Samples (NetBeans -> File
-> New Project -> Samples).
However, if I build NetBeans from source code (at that tag 11.1-beta1) ({{ant
-Dcluster.config=basic}}, it works:
!ant+NetBeans11.1-beta1.png|width=552,height=411!!distNetBeans11.1-beta1.png|width=552,height=411!
Checking both versions, I see that the released one doesn't include the
{{org-netbeans-modules-openjfx-samples.jar}}, while the ant built has the
{{openjfx.samples}} build folder with the compiled classes.
So it looks like the released version is missing a packaging task that
generates the jar of the new module {{openjfx.samples}} and includes it with
the rest of the javafx modules.
What script do we need to modify to include this new module?
was (Author: jpereda):
The PR was merged (see
[commit|https://github.com/apache/netbeans/commit/340934ecdbb38c6ceab405a1df99ffa1456e8401]),
NetBeans 11.1-beta1 was tagged after that, but the current released version,
downloaded from
[here|https://builds.apache.org/job/netbeans-release/413/artifact/dist/netbeans-11.1-beta1-bin.zip],
doesn't show the {{OpenJFX}} category when opening Samples (NetBeans -> File
-> New Project -> Samples).
!distNetBeans11.1-beta1.png!
However, if I build NetBeans from source code (at that tag 11.1-beta1) ({{ant
-Dcluster.config=basic}}, it works:
!ant+NetBeans11.1-beta1.png!
Checking both versions, I see that the released one doesn't include the
{{org-netbeans-modules-openjfx-samples.jar}}, while the ant built has the
{{openjfx.samples}} build folder with the compiled classes.
So it looks like the released version is missing a packaging task that
generates the jar of the new module {{openjfx.samples}} and includes it with
the rest of the javafx modules.
What script do we need to modify to include this new module?
> Bundle the Open JFX NetBeans samples with Apache NetBeans
> ---------------------------------------------------------
>
> Key: NETBEANS-2506
> URL: https://issues.apache.org/jira/browse/NETBEANS-2506
> Project: NetBeans
> Issue Type: Bug
> Reporter: Geertjan Wielenga
> Assignee: Jose Pereda
> Priority: Major
> Labels: pull-request-available
> Attachments: ant+NetBeans11.1-beta1.png, distNetBeans11.1-beta1.png
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In the Samples category in the New Project dialog, create a new subcategory
> named "OpenJFX" and there make the following samples available, to have them
> ready to be used out of the box:
> https://github.com/openjfx/samples/tree/master/IDE/NetBeans
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
