This is an automated email from the ASF dual-hosted git repository.
tmysik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 2b67b11 Fix unit tests for ConvertVisibilitySuggestion
new c67e1b6 Merge pull request #1606 from junichi11/fix-unit-tests
2b67b11 is described below
commit 2b67b114ae54d0d4ae8fcc3a3e6848e64b40c361
Author: Junichi Yamamoto <[email protected]>
AuthorDate: Fri Nov 1 14:02:34 2019 +0900
Fix unit tests for ConvertVisibilitySuggestion
- Fix typo of abstract class name
- Fix the interface name of test data because there is the same interface
name in testImplementAbstractMethodsHint.php (from InterfaceName to
VisibilityInterface)
---
.../ConvertVisibilitySuggestion/testConvertVisibility.php | 4 ++--
.../testConvertVisibilityAbstractClass.php | 2 +-
...Class.php.testConvertVisibilitySuggestionAbstractClassFix_01.fixed | 2 +-
...Class.php.testConvertVisibilitySuggestionAbstractClassFix_02.fixed | 2 +-
...Class.php.testConvertVisibilitySuggestionAbstractClassFix_03.fixed | 2 +-
...Class.php.testConvertVisibilitySuggestionAbstractClassFix_04.fixed | 2 +-
...Class.php.testConvertVisibilitySuggestionAbstractClassFix_05.fixed | 2 +-
...Class.php.testConvertVisibilitySuggestionAbstractClassFix_06.fixed | 2 +-
.../ConvertVisibilitySuggestion/testConvertVisibilityInterface.php | 2 +-
...Interface.php.testConvertVisibilitySuggestionInterfaceFix_01.fixed | 2 +-
...Interface.php.testConvertVisibilitySuggestionInterfaceFix_02.fixed | 2 +-
...Interface.php.testConvertVisibilitySuggestionInterfaceFix_03.fixed | 2 +-
12 files changed, 13 insertions(+), 13 deletions(-)
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibility.php
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibility.php
index 0852432..f68fe1a 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibility.php
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibility.php
@@ -63,7 +63,7 @@ class Visibility {
}
-abstract class AbstarctClass {
+abstract class AbstractVisibilityClass {
abstract function abstractImplicitPublic();
abstract public function abstractPublic();
@@ -75,7 +75,7 @@ abstract class AbstarctClass {
abstract protected static function abstractProtectedStatic();
}
-interface InterfaceName {
+interface VisibilityInterface {
const INTERFACE_IMPLICIT_CONST = "implicit";
public const INTERFACE_PUBLIC_CONST = "implicit";
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php
index 08efd27..c9424e9 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php
@@ -1,6 +1,6 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-abstract class AbstarctClass {
+abstract class AbstractVisibilityClass {
abstract function abstractImplicitPublic();
abstract public function abstractPublic();
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_01.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_01.fixed
index 3212776..4ef72bd 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_01.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_01.fixed
@@ -1,6 +1,6 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-abstract class AbstarctClass {
+abstract class AbstractVisibilityClass {
abstract public function abstractImplicitPublic();
abstract public function abstractPublic();
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_02.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_02.fixed
index 2898976..8d8b5ad 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_02.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_02.fixed
@@ -1,6 +1,6 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-abstract class AbstarctClass {
+abstract class AbstractVisibilityClass {
abstract function abstractImplicitPublic();
abstract protected function abstractPublic();
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_03.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_03.fixed
index b68125e..b0a0849 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_03.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_03.fixed
@@ -1,6 +1,6 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-abstract class AbstarctClass {
+abstract class AbstractVisibilityClass {
abstract function abstractImplicitPublic();
abstract public function abstractPublic();
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_04.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_04.fixed
index a10e104..af195df 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_04.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_04.fixed
@@ -1,6 +1,6 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-abstract class AbstarctClass {
+abstract class AbstractVisibilityClass {
abstract function abstractImplicitPublic();
abstract public function abstractPublic();
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_05.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_05.fixed
index 5c3fcad..37f21b8 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_05.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_05.fixed
@@ -1,6 +1,6 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-abstract class AbstarctClass {
+abstract class AbstractVisibilityClass {
abstract function abstractImplicitPublic();
abstract public function abstractPublic();
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_06.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_06.fixed
index 4e41fce..52f3cdf 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_06.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityAbstractClass.php.testConvertVisibilitySuggestionAbstractClassFix_06.fixed
@@ -1,6 +1,6 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-abstract class AbstarctClass {
+abstract class AbstractVisibilityClass {
abstract function abstractImplicitPublic();
abstract public function abstractPublic();
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php
index 3122105..2ba8fbe 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php
@@ -1,7 +1,7 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-interface InterfaceName {
+interface VisibilityInterface {
const INTERFACE_IMPLICIT_CONST = "implicit";
public const INTERFACE_PUBLIC_CONST = "implicit";
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_01.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_01.fixed
index 893801f..3115f42 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_01.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_01.fixed
@@ -1,7 +1,7 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-interface InterfaceName {
+interface VisibilityInterface {
public const INTERFACE_IMPLICIT_CONST = "implicit";
public const INTERFACE_PUBLIC_CONST = "implicit";
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_02.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_02.fixed
index bbefb90..6c7f2f3 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_02.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_02.fixed
@@ -1,7 +1,7 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-interface InterfaceName {
+interface VisibilityInterface {
const INTERFACE_IMPLICIT_CONST = "implicit";
public const INTERFACE_PUBLIC_CONST = "implicit";
diff --git
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_03.fixed
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_03.fixed
index e706dc0..95d859d 100644
---
a/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_03.fixed
+++
b/php/php.editor/test/unit/data/testfiles/verification/ConvertVisibilitySuggestion/testConvertVisibilityInterface.php.testConvertVisibilitySuggestionInterfaceFix_03.fixed
@@ -1,7 +1,7 @@
<?php
// Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements; and to You under the Apache License, Version
2.0.
-interface InterfaceName {
+interface VisibilityInterface {
const INTERFACE_IMPLICIT_CONST = "implicit";
public const INTERFACE_PUBLIC_CONST = "implicit";
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
