This is an automated email from the ASF dual-hosted git repository. lkishalmi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push: new 3755ec8 [NETBEANS-3586] : Same module name when created, breaks things. Showing null pointer exception on screen 3755ec8 is described below commit 3755ec85188457effa3aa9f8de1644b2c5ed7559 Author: singh-akhilesh <akhilesh.s.si...@oracle.com> AuthorDate: Mon Dec 16 12:29:39 2019 +0530 [NETBEANS-3586] : Same module name when created, breaks things. Showing null pointer exception on screen --- .../modules/java/j2semodule/ui/wizards/Bundle.properties | 1 + .../java/j2semodule/ui/wizards/ModuleTargetChooserPanel.java | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/java/java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/wizards/Bundle.properties b/java/java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/wizards/Bundle.properties index 35e32c3..bf7ab20 100644 --- a/java/java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/wizards/Bundle.properties +++ b/java/java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/wizards/Bundle.properties @@ -76,6 +76,7 @@ LBL_ModuleTargetChooserPanelGUI_CreatedModule_Label=&Created Module\: LBL_ModuleTargetChooserPanelGUI_NewModulePrefix=new ERR_ModuleTargetChooser_InvalidModule=The Module Name is not valid ERR_ModuleTargetChooser_InvalidFolder=The Module is not a folder +ERR_ModuleTargetChooser_AlreadyExistModule=The Module Name already exists INFO_ModuleTargetChooser_ProvideModuleName=Provide valid Module name AD_documentNameTextField=N/A diff --git a/java/java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/wizards/ModuleTargetChooserPanel.java b/java/java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/wizards/ModuleTargetChooserPanel.java index d061372..aafaa46 100644 --- a/java/java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/wizards/ModuleTargetChooserPanel.java +++ b/java/java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/wizards/ModuleTargetChooserPanel.java @@ -20,6 +20,7 @@ package org.netbeans.modules.java.j2semodule.ui.wizards; import java.awt.Component; import java.util.ArrayList; +import java.util.Arrays; import java.util.List; import java.util.StringTokenizer; import javax.swing.event.ChangeEvent; @@ -121,6 +122,10 @@ public class ModuleTargetChooserPanel implements WizardDescriptor.Panel<WizardDe setErrorMessage("ERR_ModuleTargetChooser_InvalidFolder"); // NOI18N return false; } + if(isModuleNameAlreadyExists(gui.getRootFolder(), gui.getTargetName())){ + setErrorMessage("ERR_ModuleTargetChooser_AlreadyExistModule"); // NOI18N + return false; + } return true; } @@ -185,6 +190,10 @@ public class ModuleTargetChooserPanel implements WizardDescriptor.Panel<WizardDe } return true; } + + private boolean isModuleNameAlreadyExists(FileObject root, final String newModuleName){ + return Arrays.stream(root.getChildren()).anyMatch(module -> module.getName().equalsIgnoreCase(newModuleName)); + } private void setErrorMessage(String key) { if (key == null) { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists