[
https://issues.apache.org/jira/browse/NETBEANS-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011047#comment-17011047
]
MeFisto94 commented on NETBEANS-3660:
-------------------------------------
Hmm, so I tried to trace it a bit in the source code and we get until
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/JavaUtils.c#L293]
as the output is printed, Actually even
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/JavaUtils.c#L244]
is still printed, but then we land at either
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/Launcher.c#L244]
or
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/Launcher.c#L282]
/
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/Launcher.c#L363]
[no java was found]
So this means to me that
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/JavaUtils.c#L242]
doesn't set result to ERROR_OK.
Being overly correct, the following if should contain an isOk(result),
otherwise javaProps->version is set to something unparsable and especially the
"some java there" confusing message is printed out.
I can't understand how your example works, but
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/JavaUtils.c#L125]
doesn't seem java 10+ ready at all, starting with the fact that
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/JavaUtils.c#L129]
is not true anymore with versions starting 10 (they have two leading numbers
now. Previous: 1.8 -> Java 8, now: 10.0 Java 10).
This and the build number now is specified using "+" instead of "-" ->
[https://github.com/apache/netbeans/blob/6782946e1363495c2bbea2ce1861f77351b130bb/nbi/engine/native/launcher/windows/src/JavaUtils.c#L169
]
D'OH!!!
I just checked the file
[https://github.com/apache/netbeans/blob/master/nbi/engine/native/launcher/windows/src/JavaUtils.c]
to master,
[https://github.com/apache/netbeans/commit/e465842e724d727f0f3b4d3b19f1c9587d9b93fd]
solves the + issue, and a more previous commit changes only looking at the
first digit.
I'll close this as duplicate of 1157 and 2381, but could you please tell me how
I can upgrade my installer stubs? It seems to be using the old ones with a
recent IDE.
> Netbeans Installer fails with bundled JDK
> -----------------------------------------
>
> Key: NETBEANS-3660
> URL: https://issues.apache.org/jira/browse/NETBEANS-3660
> Project: NetBeans
> Issue Type: Bug
> Components: platform - JDK Problems
> Affects Versions: 8.2
> Reporter: MeFisto94
> Priority: Major
>
> For our Netbeans Platform Application
> ([https://github.com/jMonkeyEngine/sdk/releases/tag/v3.3.0-beta1-sdk1)] at
> least the 64bit Windows Version of the Netbeans Installer is broken.
>
> Here's a log
> ```
> [...]
> [2020-01-03 00:25:54.511]> ... directory :
> C:\Users\Marc\AppData\Local\Temp\\NBI06365.tmp\_jvm\lib\server
> [2020-01-03 00:25:54.512]> ... listing directory
> C:\Users\Marc\AppData\Local\Temp\\NBI06365.tmp\_jvm\lib\server
> [2020-01-03 00:25:54.513]> ... java hierarchy there
> [2020-01-03 00:25:54.514]> Create new process:
> [2020-01-03 00:25:54.515]> command :
> C:\Users\Marc\AppData\Local\Temp\\NBI06365.tmp\_jvm\bin\java.exe -classpath
> C:\Users\Marc\AppData\Local\Temp\\NBI06365.tmp TestJDK
> [2020-01-03 00:25:54.516]> directory : C:\Users\Marc\Downloads
> [2020-01-03 00:25:54.544]> ... process created
> [2020-01-03 00:25:54.645]> ... process finished his work
> [2020-01-03 00:25:54.649]> output :
> 11.0.5
> 11.0.5+10
> AdoptOpenJDK
> Windows 10
> amd64
> [2020-01-03 00:25:54.650]> java.version = 11.0.5
> [2020-01-03 00:25:54.651]> java.vm.version = 11.0.5+10
> [2020-01-03 00:25:54.651]> java.vendor = AdoptOpenJDK
> [2020-01-03 00:25:54.653]> os.name = Windows 10
> [2020-01-03 00:25:54.654]> os.arch = amd64
> [2020-01-03 00:25:54.654]>
> [2020-01-03 00:25:54.654]> ... getting java version from string : 11.0.5+10
> [2020-01-03 00:25:54.655]> ... some java there
> [2020-01-03 00:25:54.656]> ... no java at
> C:\Users\Marc\AppData\Local\Temp\\NBI06365.tmp\_jvm
> [2020-01-03 00:25:54.657]> ... check private jre at
> C:\Users\Marc\AppData\Local\Temp\\NBI06365.tmp\_jvm\jre
> [2020-01-03 00:25:54.658]> ... not a java hierarchy
> [2020-01-03 00:25:54.659]> ... no java was found
> [2020-01-03 00:26:00.595]> No compatible jvm was found on the system
> [2020-01-03 00:26:00.596]> ... deleting temporary directory
> [2020-01-03 00:26:00.815]> ... EXIT status : 1010
> [2020-01-03 00:26:00.816]> ... EXIT code : 0
> [2020-01-03 00:26:00.817]> Closing launcher properties
> ```
>
> Now I don't know how to proceed as it can successfully run the test and
> extract the version string and concluding `some java there`, but it then
> concludes `no java at C:\..._jvm` (Actually it is in the bin\ folder there...)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
