[ https://issues.apache.org/jira/browse/NETBEANSINFRA-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063765#comment-17063765 ]
Jaroslav Tulach edited comment on NETBEANSINFRA-12 at 3/21/20, 6:08 AM: ------------------------------------------------------------------------ I guess something is still broken. With following test-case: {code:xml} <?xml version="1.0" encoding="UTF-8"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> <modelVersion>4.0.0</modelVersion> <groupId>org.apidesign.test</groupId> <artifactId>VerifyHtmlUI</artifactId> <version>1.0-SNAPSHOT</version> <packaging>jar</packaging> <properties> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <maven.compiler.source>8</maven.compiler.source> <maven.compiler.target>8</maven.compiler.target> </properties> <repositories> <repository> <id>Nb12.0</id> <url>https://builds.apache.org/job/netbeans-TLP/job/netbeans/job/release120/lastSuccessfulBuild/artifact/mavenrepository/</url> </repository> </repositories> <dependencies> <dependency> <groupId>org.netbeans.api</groupId> <artifactId>org-netbeans-api-htmlui</artifactId> <version>RELEASE120</version> </dependency> </dependencies> </project> {code} I am getting following error: {code:bash} The following artifacts could not be resolved: org.netbeans.html:net-java-html:jar:1.7, org.netbeans.html:net-java-html-boot:jar:1.7, org.netbeans.html:net-java-html-boot-fx:jar:1.7, org.netbeans.html:net-java-html-json:jar:1.7, org.netbeans.html:org-netbeans-html-ko4j:jar:1.7, org.netbeans.html:org-netbeans-html-xhr4j:jar:1.7: Failure to find org.netbeans.html:net-java-html:jar:1.7 {code} The Maven central repository contains archetypes with dots like [net.java.html.boot|https://search.maven.org/artifact/org.netbeans.html/net.java.html.boot/1.7/bundle] - somehow the system converts the real Maven coordinates to NetBeans like ones (where "-" is used traditionally instead of "."). It would be nice to add the above {{pom.xml}} as an integration test somewhere - either to the plugin or to the [TLP NetBeans job|https://builds.apache.org/job/netbeans-TLP/job/netbeans/]. Better to have an automatic test than to check the release consistency manually everytime. It would be even better if we could test whole clusters. For example: {code:xml} <?xml version="1.0" encoding="UTF-8"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> <modelVersion>4.0.0</modelVersion> <groupId>org.apidesign.test</groupId> <artifactId>VerifyHtmlUI</artifactId> <version>1.0-SNAPSHOT</version> <packaging>nbm-application</packaging> <properties> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <maven.compiler.source>8</maven.compiler.source> <maven.compiler.target>8</maven.compiler.target> </properties> <repositories> <repository> <id>Nb12.0</id> <url>https://builds.apache.org/job/netbeans-TLP/job/netbeans/job/release120/lastSuccessfulBuild/artifact/mavenrepository/</url> </repository> </repositories> <dependencies> <dependency> <groupId>org.netbeans.cluster</groupId> <artifactId>platform</artifactId> <version>RELEASE120</version> <type>pom</type> </dependency> </dependencies> <build> <plugins> <plugin> <groupId>org.apache.netbeans.utilities</groupId> <artifactId>nbm-maven-plugin</artifactId> <version>4.3</version> <extensions>true</extensions> <configuration> <brandingToken>test</brandingToken> </configuration> </plugin> </plugins> </build> </project> {code} is broken as well. With such sample project we could check consistency of each cluster! was (Author: jtulach): I guess something is still broken. With following test-case: {code:xml} <?xml version="1.0" encoding="UTF-8"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> <modelVersion>4.0.0</modelVersion> <groupId>org.apidesign.test</groupId> <artifactId>VerifyHtmlUI</artifactId> <version>1.0-SNAPSHOT</version> <packaging>jar</packaging> <properties> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <maven.compiler.source>8</maven.compiler.source> <maven.compiler.target>8</maven.compiler.target> </properties> <repositories> <repository> <id>Nb12.0</id> <url>https://builds.apache.org/job/netbeans-TLP/job/netbeans/job/release120/lastSuccessfulBuild/artifact/mavenrepository/</url> </repository> </repositories> <dependencies> <dependency> <groupId>org.netbeans.api</groupId> <artifactId>org-netbeans-api-htmlui</artifactId> <version>RELEASE120</version> </dependency> </dependencies> </project> {code} I am getting following error: {code:bash} The following artifacts could not be resolved: org.netbeans.html:net-java-html:jar:1.7, org.netbeans.html:net-java-html-boot:jar:1.7, org.netbeans.html:net-java-html-boot-fx:jar:1.7, org.netbeans.html:net-java-html-json:jar:1.7, org.netbeans.html:org-netbeans-html-ko4j:jar:1.7, org.netbeans.html:org-netbeans-html-xhr4j:jar:1.7: Failure to find org.netbeans.html:net-java-html:jar:1.7 {code} The Maven central repository contains archetypes with dots like [net.java.html.boot|https://search.maven.org/artifact/org.netbeans.html/net.java.html.boot/1.7/bundle] - somehow the system converts the real Maven coordinates to NetBeans like ones (where "-" is used traditionally instead of "."). It would be nice to add the above {{pom.xml}} as an integration test somewhere - either to the plugin or to the [TLP NetBeans job|https://builds.apache.org/job/netbeans-TLP/job/netbeans/]. Better to have an automatic test than to check the release consistency manually everytime. Btw. I tried to change the above dependency to {code:xml} <dependency> <groupId>org.netbeans.cluster</groupId> <artifactId>platform</artifactId> <version>RELEASE120</version> <type>pom<type> </dependency> {code} that is broken as well (but maybe I am doing something wrong). Anyway the idea would be: with such sample project we could check consistency of each cluster. > org.netbeans.external:net.java.html & co. have wrong groupId/artifactId > ----------------------------------------------------------------------- > > Key: NETBEANSINFRA-12 > URL: https://issues.apache.org/jira/browse/NETBEANSINFRA-12 > Project: Apache NetBeans Infra > Issue Type: Bug > Components: MU - Apache NetBeans nb repository plugin > Reporter: Jaroslav Tulach > Assignee: Eric Barboni > Priority: Minor > Labels: pull-request-available > Fix For: NB Repository Plugin 1.6 > > Time Spent: 1h > Remaining Estimate: 0h > > While working on https://github.com/apache/netbeans/pull/1738 I realized that > the Maven name given to org.netbeans.external:net.java.html:1.7 is wrong and > it needlessly complicates the integration with rest of the utilities that > rely on upstream org.netbeans.html:net.java.html:1.7 name. > There is a code that tries to {{findExternal}} in Maven Utilities module: > https://github.com/apache/netbeans-mavenutils-nb-repository-plugin/blob/master/src/main/java/org/apache/netbeans/nbm/repository/PopulateRepositoryMojo.java#L426 > However it is not yet implemented. Anyway, many of our OSGi bundles come from > Maven central and they should be referenced with their real Maven > co-ordinates. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists