[ 
https://issues.apache.org/jira/browse/NETBEANSINFRA-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frederic Simons updated NETBEANSINFRA-189:
------------------------------------------
    Description: 
By improving the copying of the modules files in this [pull 
request|https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/8], 
I overlooked some major flaw in my code.

Using JarOutputstream, it is not easily possible to update a single entry of a 
zip (in this case jar) file.

Please revert the mentioned pull request to restore the original code 
behaivior. I have a new pull request in the pipeline that actually does what 
the original pull request intended and also keeps the optimized performance 
without truncating files.

Best regards
 Frederic Simons

  was:
By improving the copying of the modules files in this [pull 
request|https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/8], 
I overlooked some major flaw in my code.

Using JarOutputstream, it is not easily possible to update a single entry of a 
zip (in this case jar) file.

Please revert the mentioned pull request to restore the original code 
behaivior. I have a new pull request in the pipeline that actually does what 
the original pull request intended and also keeps the optimized performance 
without truncating files.

I  apologize for testing thorougly enough

Best regards
Frederic Simons


> Copied files get truncated
> --------------------------
>
>                 Key: NETBEANSINFRA-189
>                 URL: https://issues.apache.org/jira/browse/NETBEANSINFRA-189
>             Project: Apache NetBeans Infra
>          Issue Type: Bug
>          Components: MU - Apache NetBeans NBM maven plugin
>            Reporter: Frederic Simons
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: NBM Maven Plugin 4.6
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> By improving the copying of the modules files in this [pull 
> request|https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/8],
>  I overlooked some major flaw in my code.
> Using JarOutputstream, it is not easily possible to update a single entry of 
> a zip (in this case jar) file.
> Please revert the mentioned pull request to restore the original code 
> behaivior. I have a new pull request in the pipeline that actually does what 
> the original pull request intended and also keeps the optimized performance 
> without truncating files.
> Best regards
>  Frederic Simons



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to