[ https://issues.apache.org/jira/browse/NETBEANS-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jose updated NETBEANS-4854: --------------------------- Description: In [PR-2350|https://github.com/apache/netbeans/pull/2350] Matthias Bläsing suggest a fix. This fix was about the wrong use of *${nb_all}* in some cases e.g. Wrong use: test-unit-sys-prop.test.junit.jar=${nb_all}/libs.junit4/external/junit-4.12.jar Should be: test-unit-sys-prop.test.junit.jar=${nb_all}/*platform*/libs.junit4/external/junit-4.12.jar This indicate that *${nb_all}* is equal to the source root directory of NetBeans and below this directory are the major projects (e.g. enterprise, ide, java, nbbuild). I search the usage of *${nb_all}* and find some exact cases like the one Matthias indicate and some others like: ${nb_all}/javahelp/external/jhall-2.0_05.jar Should be: ${nb_all}/*platform*/javahelp/external/jhall-2.0_05.jar I fix this wrong use cases and did the following testing. I will execute the unit testing of every module involved in this change and compare them. was: NetBeans Testing: - Full build done - Started NetBeans and ensure the log didn't have any errors or new warnings - Checked every path changed in this PR was correct > Fix wrong classpaths > -------------------- > > Key: NETBEANS-4854 > URL: https://issues.apache.org/jira/browse/NETBEANS-4854 > Project: NetBeans > Issue Type: Bug > Components: java - Classpath > Affects Versions: 12.1 > Reporter: Jose > Assignee: Jose > Priority: Minor > Labels: pull-request-available > Fix For: 12.2 > > Time Spent: 10m > Remaining Estimate: 0h > > In [PR-2350|https://github.com/apache/netbeans/pull/2350] Matthias Bläsing > suggest a fix. This fix was about the wrong use of *${nb_all}* in some cases > e.g. > Wrong use: > > test-unit-sys-prop.test.junit.jar=${nb_all}/libs.junit4/external/junit-4.12.jar > Should be: > > test-unit-sys-prop.test.junit.jar=${nb_all}/*platform*/libs.junit4/external/junit-4.12.jar > This indicate that *${nb_all}* is equal to the source root directory of > NetBeans and below this directory are the major projects (e.g. enterprise, > ide, java, nbbuild). > I search the usage of *${nb_all}* and find some exact cases like the one > Matthias indicate and some others like: > ${nb_all}/javahelp/external/jhall-2.0_05.jar > Should be: > ${nb_all}/*platform*/javahelp/external/jhall-2.0_05.jar > I fix this wrong use cases and did the following testing. I will execute the > unit testing of every module involved in this change and compare them. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists