[netbeans] 02/03: Ensure declared constructors are always processed in the same order

[lkishalmi]

This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git

commit 8a40154bd00cc31d6675556777ad66c772ea520f
Author: Sven Reimers <sven.reim...@gmail.com>
AuthorDate: Fri Jan 8 22:56:49 2021 +0100

    Ensure declared constructors are always processed in the same order
---
 .../groovy/editor/api/parser/GroovyVirtualSourceProvider.java    | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git 
a/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyVirtualSourceProvider.java
 
b/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyVirtualSourceProvider.java
index 3396611..b69bd3f 100644
--- 
a/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyVirtualSourceProvider.java
+++ 
b/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyVirtualSourceProvider.java
@@ -28,10 +28,12 @@ import java.io.StringWriter;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.Comparator;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Set;
+import java.util.stream.Collectors;
 import org.codehaus.groovy.ast.ClassHelper;
 import org.codehaus.groovy.ast.ClassNode;
 import org.codehaus.groovy.ast.ConstructorNode;
@@ -476,7 +478,12 @@ public class GroovyVirtualSourceProvider implements 
VirtualSourceProvider {
             ClassNode superType = type.getSuperClass();
 
             boolean hadPrivateConstructor = false;
-            for (ConstructorNode c : superType.getDeclaredConstructors()) {
+            
+            List<ConstructorNode> constructorNodes = superType
+                    .getDeclaredConstructors().stream()
+                    
.sorted(Comparator.comparing(ConstructorNode::getTypeDescriptor))
+                    .collect(Collectors.toList());
+            for (ConstructorNode c : constructorNodes) {
                 // Only look at things we can actually call
                 if (c.isPublic() || c.isProtected()) {
                     return c.getParameters();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists