[
https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475665#comment-17475665
]
Thomas Schapitz edited comment on NETBEANS-6347 at 1/13/22, 7:17 PM:
---------------------------------------------------------------------
Not exactly understanding what you are saying, but: It doesn't matter, whether
I start with an empty userdir/config/Projects, or content automigrated from a
previous installation:
!image-2022-01-13-19-09-32-623.png!
Adding a name hier and clicking OK, will take me to the result initially shown,
and producing this as (sans Copyright-Header:
<actions>
<action>
<actionName>CUSTOM-aas</actionName>
<displayName>aas</displayName>
</action>
</actions>
Starting with something meaningful, like this:
<actions>
<action>
<actionName>CUSTOM-Version Updates</actionName>
<displayName>Version Updates</displayName>
<goals>
<goal>versions:display-plugin-updates</goal>
<goal>versions:display-parent-updates</goal>
<goal>versions:display-property-updates</goal>
<goal>versions:display-dependency-updates</goal>
</goals>
</action>
</actions>
will allow you to edit goals and parameters for this one, if you click it in
the window, but adding another one, still gets you nowhere:
!image-2022-01-13-19-27-19-230.png!
Scaling is broken too: I could do without the blank space between the controls
and OK/Cancel/Help, which makes up nearly half of the panel. But here, the
Disabled "Disabled' button (which shouldn't be disabled at all, and likely be
labeled 'Enable', if the goal is 'Disabled') gets clipped until it vanishes,
because its enclosing box is to small, while the Properties Multiline Textbox
shows just half of a line.
Afterwards, the definitions look like this:
<actions>
<action>
<actionName>CUSTOM-Version Updates</actionName>
<displayName>Version Updates</displayName>
<goals>
<goal>versions:display-plugin-updates</goal>
<goal>versions:display-parent-updates</goal>
<goal>versions:display-property-updates</goal>
<goal>versions:display-dependency-updates</goal>
</goals>
</action>
<action>
<actionName>CUSTOM-anothergoal</actionName>
<displayName>anothergoal</displayName>
<properties>
<skipTests>true</skipTests>
</properties>
</action>
</actions>
I would think that:
* firstly, the new definition shouldn't be created in disabled state in the
first place,
* secondly, it shouldn't make a difference to the three textboxes for goals,
profiles & packagings, whether the definition is disabled or not, it should be
possible to edit them in the disable state, as is the case for the multiline
properties box and the Add-Button to its left.
* 3rd. whether those five controls are active should hinge solely on whether
one of the definitions in the list above has been {*}selected{*}.
* If there is none selected, these controls should be disabled and empty
Maybe it is a solution, to put the five controls for a single definition into a
group, and en/disable the whole group?
Come to think of all this: It would also be better, if we drop the pop up
dialogue asking for the action name, and replace that with another editable
text control, so we may be able to edit the name later too. Alas, this would
make disabling rules a bit more complicated Possible path: on pressing Add
(Goal), insert a dummy line <new definition> into the list of definitions,
whose text gets fixed as it is typed into the control below.
was (Author: taps):
Not exactly understanding what you are saying, but: It doesn't matter, whether
I start with an empty userdir/config/Projects, or content automigrated from a
previous installation:
!image-2022-01-13-19-09-32-623.png!
Adding a name hier and clicking OK, will take me to the result initially shown,
and producing this as (sans Copyright-Header:
<actions>
<action>
<actionName>CUSTOM-aas</actionName>
<displayName>aas</displayName>
</action>
</actions>
Starting with something meaningful, like this:
<actions>
<action>
<actionName>CUSTOM-Version Updates</actionName>
<displayName>Version Updates</displayName>
<goals>
<goal>versions:display-plugin-updates</goal>
<goal>versions:display-parent-updates</goal>
<goal>versions:display-property-updates</goal>
<goal>versions:display-dependency-updates</goal>
</goals>
</action>
</actions>
will allow you to edit goals and parameters for this one, if you click it in
the window, but adding another one, still gets you nowhere:
!image-2022-01-13-19-27-19-230.png!
And scaling is mentioned: scaling is broken too: I could do without the blank
space between the controls and OK/Cancel/Help, which makes up nearly half of
the panel. But here, the Disabled "Disabled' button (which shouldn't be
disabled at all, and likely be labeled 'Enable', if the goal is 'Disabled',
vanishes, because its enclosing box is to small, while the Properties Multiline
Textbox shows just half of a line.
Afterwards, the definitions look like this:
<actions>
<action>
<actionName>CUSTOM-Version Updates</actionName>
<displayName>Version Updates</displayName>
<goals>
<goal>versions:display-plugin-updates</goal>
<goal>versions:display-parent-updates</goal>
<goal>versions:display-property-updates</goal>
<goal>versions:display-dependency-updates</goal>
</goals>
</action>
<action>
<actionName>CUSTOM-anothergoal</actionName>
<displayName>anothergoal</displayName>
<properties>
<skipTests>true</skipTests>
</properties>
</action>
</actions>
I would think that:
* firstly, the new definition shouldn't be created in disabled state in the
first place,
* secondly, it shouldn't make a difference to the three textboxes for goals,
profiles & packagings, whether the definition is disabled or not, it should be
possible to edit them in the disable state, as is the case for the multiline
properties box and the Add-Button to its left.
* 3rd. whether those five controls are active should hinge solely on whether
one of the definitions in the list above has been {*}selected{*}.
* If there is none selected, these controls should be disabled and empty
Maybe it is a solution, to put the five controls for a single definition into a
group, and en/disable the whole group?
Come to think of all this: It would also be better, if we drop the pop up
dialogue asking for the action name, and replace that with another editable
text control, so we may be able to edit the name later too. Alas, this would
make disabling rules a bit more complicated Possible path: on pressing Add
(Goal), insert a dummy line <new definition> into the list of definitions,
whose text gets fixed as it is typed into the control below.
> Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
> -------------------------------------------------------------------
>
> Key: NETBEANS-6347
> URL: https://issues.apache.org/jira/browse/NETBEANS-6347
> Project: NetBeans
> Issue Type: Bug
> Components: apisupport - Maven
> Affects Versions: 12.5, 12.6
> Reporter: Thomas Schapitz
> Assignee: Svatopluk Dedic
> Priority: Critical
> Labels: pull-request-available
> Fix For: NB13
>
> Attachments: image-2021-12-31-10-27-08-275.png,
> image-2021-12-31-10-30-58-143.png, image-2022-01-13-19-09-32-623.png,
> image-2022-01-13-19-27-19-230.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The following hardcopy illustrates the problem.
> It *is* possible, to add a new definition, but afterwards, it is no longer
> possible to maintain values for the goals & profiles, as has been the case up
> to version 12.3
> And it isn't possible to activate the definition, it get's created in
> disabled state. (Prior to 12.4, it wasn't possible to disable a definition)
> Furthermore, at least on Windows 10 / JDK 17, one may observe, that the
> alignment of the buttons with the list is botched, as the last one, "Disable"
> gets clipped, because the listbox default hight dictates the length.
> !image-2021-12-31-10-30-58-143.png!
>
> This is how it looked like up to 12.3:
> !image-2021-12-31-10-27-08-275.png!
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
