[ 
https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475678#comment-17475678
 ] 

Svatopluk Dedic commented on NETBEANS-6347:
-------------------------------------------

I just wanted to have reproduction steps and/or the buggy state so I can verify 
the supposed fix before PR gets merged. Thanks for that and for pointing out 
the layout issues - I'll look at it.

Re. the behaviour - in the first round, it is fixable by enabling 'disable' 
button just for builtin actions; this was added more or less just override 
contributed defaults (some plugins may disable some actions which user may not 
like). I filed the other issue to provide better experience / consistency 
overall - but that requires to slightly change the APIs and serialization, 
which I don't want to do just before the branching - so filed an issue to 
remind me.

> Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
> -------------------------------------------------------------------
>
>                 Key: NETBEANS-6347
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-6347
>             Project: NetBeans
>          Issue Type: Bug
>          Components: apisupport - Maven
>    Affects Versions: 12.5, 12.6
>            Reporter: Thomas Schapitz
>            Assignee: Svatopluk Dedic
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: NB13
>
>         Attachments: image-2021-12-31-10-27-08-275.png, 
> image-2021-12-31-10-30-58-143.png, image-2022-01-13-19-09-32-623.png, 
> image-2022-01-13-19-27-19-230.png
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The following hardcopy illustrates the problem.
> It *is* possible, to add a new definition, but afterwards, it is no longer 
> possible to maintain values for the goals & profiles, as has been the case up 
> to version 12.3
> And it isn't possible to activate the definition, it get's created in 
> disabled state. (Prior to 12.4, it wasn't possible to disable a definition)
> Furthermore, at least on Windows 10 / JDK 17, one may observe, that the 
> alignment of the buttons with the list is botched, as the last one, "Disable" 
> gets clipped, because the listbox default hight dictates the length.
> !image-2021-12-31-10-30-58-143.png!
>  
> This is how it looked like up to 12.3:
> !image-2021-12-31-10-27-08-275.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to