[ https://issues.apache.org/jira/browse/NETBEANS-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Svatopluk Dedic updated NETBEANS-6518: -------------------------------------- Description: There are already other modules that depend on LSP APIs, but they cannot contribute commmands to LSP clients, some weird hacks (see https://github.com/apache/netbeans/pull/4461#discussion_r936310039) must be done in integration code. Some SPI should be introduced so that the modules can expose their functions not only to the IDE, but also to lsp clients. IMHO trivial deserialization of command parameters and serialization of the command results should be handled by the LSP server module. Question: should be the LSP commands, served to external LSP clients, served also to the INTERNAL LSP client, if used ? // cc: [~dbalek] [~jlahoda] was: There are already other modules that depend on LSP APIs, but they cannot contribute commmands to LSP clients, some weird hacks (see ) must be done in integration code. Some SPI should be introduced so that the modules can expose their functions not only to the IDE, but also to lsp clients. IMHO trivial deserialization of command parameters and serialization of the command results should be handled by the LSP server module. Question: should be the LSP commands, served to external LSP clients, served also to the INTERNAL LSP client, if used ? // cc: [~dbalek] [~jlahoda] > Provide CommandProvider LSP SPI > ------------------------------- > > Key: NETBEANS-6518 > URL: https://issues.apache.org/jira/browse/NETBEANS-6518 > Project: NetBeans > Issue Type: Bug > Components: lsp > Reporter: Svatopluk Dedic > Priority: Major > > There are already other modules that depend on LSP APIs, but they cannot > contribute commmands to LSP clients, some weird hacks (see > https://github.com/apache/netbeans/pull/4461#discussion_r936310039) must be > done in integration code. Some SPI should be introduced so that the modules > can expose their functions not only to the IDE, but also to lsp clients. > IMHO trivial deserialization of command parameters and serialization of the > command results should be handled by the LSP server module. > Question: should be the LSP commands, served to external LSP clients, served > also to the INTERNAL LSP client, if used ? > // cc: [~dbalek] [~jlahoda] -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists