This is an automated email from the ASF dual-hosted git repository.

sdedic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
     new be8a151010 it is better to have wait node in VSCode for long running 
computation of children
     new 7afb635296 Merge pull request #5709 from thurka/GCN-1720
be8a151010 is described below

commit be8a151010a2edc4b4126f4f338ddc184a34e095
Author: Tomas Hurka <[email protected]>
AuthorDate: Fri Mar 24 09:42:17 2023 +0100

    it is better to have wait node in VSCode for long running computation of 
children
---
 .../netbeans/modules/java/lsp/server/explorer/TreeViewProvider.java   | 4 +---
 java/java.lsp.server/vscode/package.json                              | 4 ++++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/TreeViewProvider.java
 
b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/TreeViewProvider.java
index 5ed7cbfdcb..8cafcedc1d 100644
--- 
a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/TreeViewProvider.java
+++ 
b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/TreeViewProvider.java
@@ -476,9 +476,7 @@ public abstract class TreeViewProvider {
 
     public final CompletionStage<Node[]> getChildren(Node nodeOrNull) {
         Node node = getNodeOrRoot(nodeOrNull);
-        return CompletableFuture.supplyAsync(() -> {
-            return node.getChildren().getNodes(true);
-        }, INITIALIZE);
+        return 
CompletableFuture.completedFuture(node.getChildren().getNodes());
     }
 
     public final CompletionStage<Node> getParent(Node node) {
diff --git a/java/java.lsp.server/vscode/package.json 
b/java/java.lsp.server/vscode/package.json
index ceaa921418..76d1199d96 100644
--- a/java/java.lsp.server/vscode/package.json
+++ b/java/java.lsp.server/vscode/package.json
@@ -1012,6 +1012,10 @@
                                "uriExpression": 
"nbres:/org/netbeans/modules/db/resources/view.gif",
                                "codeicon": "open-preview"
                        },
+                       {
+                               "uriExpression": 
"nbres:/org/openide/nodes/wait.gif",
+                               "codeicon": "watch"
+                       },
                        {
                                "uriExpression": 
"nbres:/org/netbeans/modules/cloud/oracle/resources/yellow_dot.svg",
                                "codeicon": "circle-large-outline",


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to