This is an automated email from the ASF dual-hosted git repository.
mbien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git
The following commit(s) were added to refs/heads/master by this push:
new 4ca7d9c482 disable compile-on-save by default in maven projects.
new 71152a1e27 Merge pull request #5826 from mbien/cos-off
4ca7d9c482 is described below
commit 4ca7d9c4821c7e0e9fbb2ecdd2c471e8d7217d66
Author: Michael Bien <[email protected]>
AuthorDate: Sat Apr 15 02:28:11 2023 +0200
disable compile-on-save by default in maven projects.
---
java/maven/src/org/netbeans/modules/maven/api/execute/RunUtils.java | 2 +-
.../maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java | 2 +-
.../src/org/netbeans/modules/maven/api/execute/Bundle_test.properties | 2 +-
.../unit/src/org/netbeans/modules/maven/api/execute/RunUtilsTest.java | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git
a/java/maven/src/org/netbeans/modules/maven/api/execute/RunUtils.java
b/java/maven/src/org/netbeans/modules/maven/api/execute/RunUtils.java
index 5cd11e0b57..e7ff8712a3 100644
--- a/java/maven/src/org/netbeans/modules/maven/api/execute/RunUtils.java
+++ b/java/maven/src/org/netbeans/modules/maven/api/execute/RunUtils.java
@@ -148,7 +148,7 @@ public final class RunUtils {
@NbBundle.Messages({
"#compile on save: all, none",
"#NOI18N",
- "DEFAULT_COMPILE_ON_SAVE=all"
+ "DEFAULT_COMPILE_ON_SAVE=none"
})
public static boolean isCompileOnSaveEnabled(Project prj) {
AuxiliaryProperties auxprops =
prj.getLookup().lookup(AuxiliaryProperties.class);
diff --git
a/java/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java
b/java/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java
index 8da6f6ab3f..667e82fa92 100644
--- a/java/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java
+++ b/java/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java
@@ -137,7 +137,7 @@ public class CompilePanel extends javax.swing.JPanel
implements HelpCtx.Provider
@Override
public boolean getDefaultValue() {
- return cosSupported;
+ return false; // see
org.netbeans.modules.maven.api.execute.RunUtils#isCompileOnSaveEnabled
}
@Override
diff --git
a/java/maven/test/unit/src/org/netbeans/modules/maven/api/execute/Bundle_test.properties
b/java/maven/test/unit/src/org/netbeans/modules/maven/api/execute/Bundle_test.properties
index aec63c34af..9ae15f315b 100644
---
a/java/maven/test/unit/src/org/netbeans/modules/maven/api/execute/Bundle_test.properties
+++
b/java/maven/test/unit/src/org/netbeans/modules/maven/api/execute/Bundle_test.properties
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
-DEFAULT_COMPILE_ON_SAVE=none
+DEFAULT_COMPILE_ON_SAVE=all
diff --git
a/java/maven/test/unit/src/org/netbeans/modules/maven/api/execute/RunUtilsTest.java
b/java/maven/test/unit/src/org/netbeans/modules/maven/api/execute/RunUtilsTest.java
index 2f567fdcaa..d50937b1dd 100644
---
a/java/maven/test/unit/src/org/netbeans/modules/maven/api/execute/RunUtilsTest.java
+++
b/java/maven/test/unit/src/org/netbeans/modules/maven/api/execute/RunUtilsTest.java
@@ -38,14 +38,14 @@ public class RunUtilsTest {
public void testIsCompileOnSaveEnabledByDefault() {
NbBundle.setBranding(null);
boolean result = RunUtils.isCompileOnSaveEnabled(new MockPrj());
- assertTrue("By default use CoS in NetBeans IDE", result);
+ assertFalse("CoS is off by default in the NetBeans IDE", result);
}
@Test
public void testIsCompileOnSaveEnabledWithBranding() {
NbBundle.setBranding("test");
boolean result = RunUtils.isCompileOnSaveEnabled(new MockPrj());
- assertFalse("Allow branding to disable CoS", result);
+ assertTrue("Allow branding to enable CoS", result);
}
private static class MockPrj implements Project {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
