This is an automated email from the ASF dual-hosted git repository.

oyarzun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
     new 43846955ad flatlaf properties fallback to openable for rcp apps 
without editors
     new 82c6c8faed Merge pull request #6958 from oyarzun/flatlaf-options-rcp
43846955ad is described below

commit 43846955ad80f87dc97e42fb23b1cead4a954139
Author: Christian Oyarzun <[email protected]>
AuthorDate: Mon Jan 15 12:28:53 2024 -0500

    flatlaf properties fallback to openable for rcp apps without editors
---
 .../src/org/netbeans/swing/laf/flatlaf/FlatLafOptionsPanel.java  | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git 
a/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLafOptionsPanel.java
 
b/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLafOptionsPanel.java
index 553a910c89..09e8ae4f06 100644
--- 
a/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLafOptionsPanel.java
+++ 
b/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLafOptionsPanel.java
@@ -30,6 +30,7 @@ import java.util.Objects;
 import java.util.Properties;
 import javax.swing.UIManager;
 import org.netbeans.api.actions.Editable;
+import org.netbeans.api.actions.Openable;
 import org.netbeans.spi.options.OptionsPanelController;
 import org.openide.LifecycleManager;
 import org.openide.awt.Notification;
@@ -299,7 +300,13 @@ public class FlatLafOptionsPanel extends 
javax.swing.JPanel {
                 }
                 DataObject dob = DataObject.find(customProp);
                 Editable editable = dob.getLookup().lookup(Editable.class);
-                editable.edit();
+                if (editable != null) {
+                  editable.edit();
+                } else {
+                  // fallback to openable for platform apps without editor 
modules
+                  Openable openable = dob.getLookup().lookup(Openable.class);
+                  openable.open();
+                }
             } catch (Exception ex) {
                 Exceptions.printStackTrace(ex);
             }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to