[
https://issues.apache.org/jira/browse/NETBEANS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177114#comment-16177114
]
ASF GitHub Bot commented on NETBEANS-59:
----------------------------------------
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/3
Of course, it's much easier to read since there are no more newline changes.
What this patch seems to do is add an @ActionReference so we can have
shortcuts for those 3 actions.
So, as a fix I would have preferred 2 commits:
* one fixing in-place the existing actions (in order to see the actual
meat) and
* another commit refactoring the classes.
I seems the existing static inner classes might have been sufficient: you
could have just made them public. You could have introduced
SplitDocumentHorizontallyAction which just extends SplitDocumentAction and
calls super(tc, JSplitPane.HORIZONTAL_SPLIT). Same for
SplitDocumentVerticallyAction.
I believe initTopComponent only exists so you can have a no-arg constructor
which is odd because you are instantiating the actions manually (so it must
have to do with the registrations). Also, you know that `(tc instanceof
Splitable && ((Splitable)tc).canSplit())` before it's called.
So, what I am curious to learn is how does the shortcut work for your
manually created instance?
> Please add a shortcut to split the current document
> ---------------------------------------------------
>
> Key: NETBEANS-59
> URL: https://issues.apache.org/jira/browse/NETBEANS-59
> Project: NetBeans
> Issue Type: Improvement
> Components: platform - Window System
> Affects Versions: Next
> Reporter: Christian Lenz
> Attachments: menu-entries.png
>
>
> I used a plugin called flow-netbeans-markdown
> (http://plugins.netbeans.org/plugin/50964/markdown-support). This plugin has
> a preview to show the output, what I'm typing, but I only can change between
> source, history and preview via Ctrl + Alt + Page Up/Down in the same window.
> The problem is that I disabled the option "show editor toolbar" so I can't
> split the window anymore without using the mouse.
> I would like to have on one side my sourcecode and on the other side my
> preview, and this is what I would like todo with a shortcut. Type Ctrl + Alt
> + Whatever, should split the window, then I can navigate to the other view
> and type Ctrl + Alt + Page Up/Down to take the preview.
> I created a ticket here:
> https://github.com/madflow/flow-netbeans-markdown/issues/61#issuecomment-59777381
> and you can see, that the dev means that this should be a default
> functionality, to split a window with a shortcut and to show the preview via
> navigation or to split the window and show the preview with a shortcut. If
> there is a preview or similar thing available. And yes I go with this opinion.
> Regards
> Chris
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
