[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195993#comment-16195993
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
GitHub user vieiro opened a pull request:
https://github.com/apache/incubator-netbeans/pull/91
[NETBEANS-54] Module Review libs.freemarker
- Added maven coordinates to external/binaries_list for freemarker 2.3.19
(BSD 3?)
- Added headers to two source files (FreemarkerEngine.java &
FreemarkerFactory.java) and to one test file.
- All unit tests passing.
- Not adding license headers to the following test files (as some tests
would fail):
- ./test/unit/data/golden/GeneratedMethodBody.java
- ./test/unit/data/golden/ClassWithoutReplacements.java
- ./test/unit/data/golden/GeneratedMethodBody2.java
- ./test/unit/data/golden/ForceNoReplacements.java
- ./test/unit/data/golden/SimpleReplacements.java
- ./test/unit/data/licenseheader.txt
- ./test/unit/data/templates/GeneratedMethodBody.java
- ./test/unit/data/templates/ClassWithoutReplacements.java
- ./test/unit/data/templates/SimpleReplacements.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vieiro/incubator-netbeans
netbeans-54-module-review-libs.freemarker
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit ed9232dc8a05aa17123914fcb550efa72eefa2d9
Author: Antonio Vieiro <[email protected]>
Date: 2017-10-08T06:33:35Z
[NETBEANS-54] Module Review libs.freemarker
- Added maven coordinates to external/binaries_list for freemarker 2.3.19
(BSD 3?)
- Added headers to two source files (FreemarkerEngine.java &
FreemarkerFactory.java) and to one test file.
- All unit tests passing.
- Not adding license headers to the following test files (as some tests
would fail):
- ./test/unit/data/golden/GeneratedMethodBody.java
- ./test/unit/data/golden/ClassWithoutReplacements.java
- ./test/unit/data/golden/GeneratedMethodBody2.java
- ./test/unit/data/golden/ForceNoReplacements.java
- ./test/unit/data/golden/SimpleReplacements.java
- ./test/unit/data/licenseheader.txt
- ./test/unit/data/templates/GeneratedMethodBody.java
- ./test/unit/data/templates/ClassWithoutReplacements.java
- ./test/unit/data/templates/SimpleReplacements.java
----
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
