[NETBEANS-54] Modules review xml.axi - no external library - checked Rat report: excluded test-data from rat (no IP value) - disable tests that fail because referenced files were not donated - skimmed through module, did not notice additional problems
Project: http://git-wip-us.apache.org/repos/asf/incubator-netbeans/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-netbeans/commit/b810589c Tree: http://git-wip-us.apache.org/repos/asf/incubator-netbeans/tree/b810589c Diff: http://git-wip-us.apache.org/repos/asf/incubator-netbeans/diff/b810589c Branch: refs/heads/master Commit: b810589cae3398b25d37c0629a97fa309080288a Parents: 00155f1 Author: Matthias Bläsing <[email protected]> Authored: Thu Oct 5 20:38:16 2017 +0200 Committer: Matthias Bläsing <[email protected]> Committed: Wed Oct 11 19:04:53 2017 +0200 ---------------------------------------------------------------------- nbbuild/build.xml | 1 + .../modules/xml/axi/AXIModelExTest.java | 4 +++- .../modules/xml/axi/AXIModelPerfTest.java | 5 +++-- .../netbeans/modules/xml/axi/AXIModelTest.java | 11 +++++----- .../modules/xml/axi/CheckParentTest.java | 4 +++- .../modules/xml/axi/ContentModelTest.java | 4 +++- .../modules/xml/axi/ProxyComponentTest.java | 4 +++- .../xml/axi/SchemaGeneratorDatatypesTest.java | 5 +++-- .../modules/xml/axi/SchemaTransformTest.java | 13 +++++++----- .../xml/axi/datatype/DatatypeFactoryTest.java | 5 +++-- .../xml/axi/datatype/DatatypePerfTest.java | 5 +++-- .../modules/xml/axi/datatype/DatatypeTest.java | 5 +++-- .../modules/xml/axi/sync/MultiFileSyncTest.java | 4 +++- .../modules/xml/axi/sync/StateChangeTest.java | 4 +++- .../modules/xml/axi/sync/SyncDeadlockTest.java | 4 +++- .../modules/xml/axi/sync/SyncElementTest.java | 21 ++++++++++---------- .../netbeans/modules/xml/axi/sync/SyncTest.java | 7 ++++--- 17 files changed, 66 insertions(+), 40 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/nbbuild/build.xml ---------------------------------------------------------------------- diff --git a/nbbuild/build.xml b/nbbuild/build.xml index 7a59cc1..cd8f069 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -1972,6 +1972,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d <exclude name="utilities/test/unit/src/org/netbeans/modules/openfile/resources/recent_files/*" /> <!--test data--> <exclude name="**/*.url" /> <!--no degree of creativity--> <exclude name="spi.navigator/test/unit/src/org/netbeans/modules/navigator/resources/lastsel/file.lastsel_mime1" /> <!--empty file--> + <exclude name="xml.axi/test/unit/src/org/netbeans/modules/xml/axi/resources/**" /> <!-- test data --> <exclude name="xml.text/src/org/netbeans/modules/xml/text/resources/DTDExample" /> <!-- GUI sample file to demonstrate syntax highlighting --> <exclude name="xml.text/src/org/netbeans/modules/xml/text/resources/XMLExample" /> <!-- GUI sample file to demonstrate syntax highlighting --> <exclude name="xml.text/test/qa-functional/src/org/netbeans/modules/xml/text/**/data/**" /> <!-- test data --> http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelExTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelExTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelExTest.java index c92e34e..4e26276 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelExTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelExTest.java @@ -52,7 +52,9 @@ public class AXIModelExTest extends AXIModelTest { } public static Test suite() { - TestSuite suite = new TestSuite(AXIModelExTest.class); + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(AXIModelExTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelPerfTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelPerfTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelPerfTest.java index 01b37fd..067e217 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelPerfTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelPerfTest.java @@ -47,8 +47,9 @@ public class AXIModelPerfTest extends AbstractTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(AXIModelPerfTest.class); - + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(AXIModelPerfTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelTest.java index 3a0d744..875fa17 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/AXIModelTest.java @@ -57,11 +57,12 @@ public class AXIModelTest extends AbstractTestCase { public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTest(new AXIModelTest("testAXIModel")); - suite.addTest(new AXIModelTest("testAXIModelForMetaSchema")); - suite.addTest(new AXIModelTest("testRecursiveResolve1")); - suite.addTest(new AXIModelTest("testRecursiveResolve2")); - suite.addTest(new AXIModelTest("testSubstitutionGroup")); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTest(new AXIModelTest("testAXIModel")); +// suite.addTest(new AXIModelTest("testAXIModelForMetaSchema")); +// suite.addTest(new AXIModelTest("testRecursiveResolve1")); +// suite.addTest(new AXIModelTest("testRecursiveResolve2")); +// suite.addTest(new AXIModelTest("testSubstitutionGroup")); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/CheckParentTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/CheckParentTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/CheckParentTest.java index 4777ae2..113f90f 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/CheckParentTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/CheckParentTest.java @@ -37,7 +37,9 @@ public class CheckParentTest extends AbstractTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(CheckParentTest.class); + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(CheckParentTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ContentModelTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ContentModelTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ContentModelTest.java index acdc6f8..5c70c30 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ContentModelTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ContentModelTest.java @@ -37,7 +37,9 @@ public class ContentModelTest extends AbstractTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(ContentModelTest.class); + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(ContentModelTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ProxyComponentTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ProxyComponentTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ProxyComponentTest.java index 276e504..230d3d0 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ProxyComponentTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/ProxyComponentTest.java @@ -39,7 +39,9 @@ public class ProxyComponentTest extends AbstractTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(ProxyComponentTest.class); + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(ProxyComponentTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaGeneratorDatatypesTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaGeneratorDatatypesTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaGeneratorDatatypesTest.java index 38fe942..b455e83 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaGeneratorDatatypesTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaGeneratorDatatypesTest.java @@ -46,8 +46,9 @@ public class SchemaGeneratorDatatypesTest extends AbstractTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(SchemaGeneratorDatatypesTest.class); - + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(SchemaGeneratorDatatypesTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaTransformTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaTransformTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaTransformTest.java index a7d49a4..a2c92b4 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaTransformTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/SchemaTransformTest.java @@ -78,13 +78,16 @@ public class SchemaTransformTest extends AbstractTestCase { suite.addTest(new SchemaTransformTest("testLineSalamiSlice")); suite.addTest(new SchemaTransformTest("testLineVenetianBlind")); suite.addTest(new SchemaTransformTest("testLineRussianDoll")); - suite.addTest(new SchemaTransformTest("testTypes")); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTest(new SchemaTransformTest("testTypes")); //FIXME suite.addTest(new SchemaTransformTest("testLoanApp")); suite.addTest(new SchemaTransformTest("testAnnotation")); - suite.addTest(new SchemaTransformTest("testPurchaseOrder")); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTest(new SchemaTransformTest("testPurchaseOrder")); //FIXME suite.addTest(new SchemaTransformTest("testDiscardTransform")); suite.addTest(new SchemaTransformTest("testRenameAfterTransform")); - suite.addTest(new SchemaTransformTest("testNewApproach")); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTest(new SchemaTransformTest("testNewApproach")); suite.addTest(new SchemaTransformTest("testMultiSchemaInclude")); suite.addTest(new SchemaTransformTest("testMultiSchemaImport")); suite.addTest(new SchemaTransformTest("testGlobalElementReuse")); @@ -533,7 +536,7 @@ public class SchemaTransformTest extends AbstractTestCase { assertTrue("Should not be here", false); } validateSchema(axiModel.getSchemaModel()); - + // printDocument(); assertEquals("global complex types",0,getSchemaModel().getSchema().getComplexTypes().size()); assertEquals("global simple types",0,getSchemaModel().getSchema().getSimpleTypes().size()); @@ -801,7 +804,7 @@ public class SchemaTransformTest extends AbstractTestCase { assertTrue("Should not be here", false); } validateSchema(axiModel.getSchemaModel()); - + // printDocument(); assertEquals("global complex types",3,getSchemaModel().getSchema().getComplexTypes().size()); // assertEquals("global simple types",2,getSchemaModel().getSchema().getSimpleTypes().size()); http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeFactoryTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeFactoryTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeFactoryTest.java index 5751126..f71ba0b 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeFactoryTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeFactoryTest.java @@ -52,8 +52,9 @@ public class DatatypeFactoryTest extends AbstractTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(DatatypeFactoryTest.class); - + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(DatatypeFactoryTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypePerfTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypePerfTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypePerfTest.java index 8d025c1..7916cad 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypePerfTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypePerfTest.java @@ -47,8 +47,9 @@ public class DatatypePerfTest extends AbstractTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(DatatypePerfTest.class); - + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(DatatypePerfTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeTest.java index d6a0436..c1e793b 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/datatype/DatatypeTest.java @@ -50,8 +50,9 @@ public class DatatypeTest extends AbstractTestCase { public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTest(new DatatypeTest("testDatatypeEnumerations")); - suite.addTest(new DatatypeTest("testCreateDatatype")); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTest(new DatatypeTest("testDatatypeEnumerations")); +// suite.addTest(new DatatypeTest("testCreateDatatype")); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/MultiFileSyncTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/MultiFileSyncTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/MultiFileSyncTest.java index 512fb42..3e6e83f 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/MultiFileSyncTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/MultiFileSyncTest.java @@ -59,7 +59,9 @@ public class MultiFileSyncTest extends AbstractSyncTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(MultiFileSyncTest.class); + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(MultiFileSyncTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/StateChangeTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/StateChangeTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/StateChangeTest.java index 84cf79f..0152c56 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/StateChangeTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/StateChangeTest.java @@ -66,7 +66,9 @@ public class StateChangeTest extends AbstractSyncTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(StateChangeTest.class); + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(StateChangeTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncDeadlockTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncDeadlockTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncDeadlockTest.java index 927a167..87b7b0c 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncDeadlockTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncDeadlockTest.java @@ -48,7 +48,9 @@ public class SyncDeadlockTest extends AbstractSyncTestCase { } public static Test suite() { - TestSuite suite = new TestSuite(SyncDeadlockTest.class); + TestSuite suite = new TestSuite(); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTestSuite(SyncDeadlockTest.class); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncElementTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncElementTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncElementTest.java index 2710047..ee644a1 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncElementTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncElementTest.java @@ -70,16 +70,17 @@ public class SyncElementTest extends AbstractSyncTestCase { public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTest(new SyncElementTest("testRemoveElementFromType")); - suite.addTest(new SyncElementTest("testRemoveAttributeFromAttrGroup")); - suite.addTest(new SyncElementTest("testChangeType")); - suite.addTest(new SyncElementTest("testChangeAttributeRef")); - suite.addTest(new SyncElementTest("testChangeTypeContent")); - suite.addTest(new SyncElementTest("testChangeNameOfElement")); - suite.addTest(new SyncElementTest("testRemoveGlobalElement")); - suite.addTest(new SyncElementTest("testAddGlobalElement")); - suite.addTest(new SyncElementTest("testChangeElementRef")); - suite.addTest(new SyncElementTest("testChangeBase")); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTest(new SyncElementTest("testRemoveElementFromType")); +// suite.addTest(new SyncElementTest("testRemoveAttributeFromAttrGroup")); +// suite.addTest(new SyncElementTest("testChangeType")); +// suite.addTest(new SyncElementTest("testChangeAttributeRef")); +// suite.addTest(new SyncElementTest("testChangeTypeContent")); +// suite.addTest(new SyncElementTest("testChangeNameOfElement")); +// suite.addTest(new SyncElementTest("testRemoveGlobalElement")); +// suite.addTest(new SyncElementTest("testAddGlobalElement")); +// suite.addTest(new SyncElementTest("testChangeElementRef")); +// suite.addTest(new SyncElementTest("testChangeBase")); return suite; } http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/b810589c/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncTest.java ---------------------------------------------------------------------- diff --git a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncTest.java b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncTest.java index d608ac5..340dbee 100644 --- a/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncTest.java +++ b/xml.axi/test/unit/src/org/netbeans/modules/xml/axi/sync/SyncTest.java @@ -50,9 +50,10 @@ public class SyncTest extends AbstractSyncTestCase { public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTest(new SyncTest("testSync")); - suite.addTest(new SyncTest("testOTASyncPerformance")); - //suite.addTest(new SyncPerfTest("testHealthcareSchemaSyncPerformance")); +// Disabled as referenced XSD file were partly not donated by oracle to apache +// suite.addTest(new SyncTest("testSync")); +// suite.addTest(new SyncTest("testOTASyncPerformance")); +// //suite.addTest(new SyncPerfTest("testHealthcareSchemaSyncPerformance")); return suite; }
