[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205058#comment-16205058
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/145#discussion_r144712225
--- Diff:
apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/actionListener.javx
---
@@ -1,41 +1,22 @@
-<#--
-DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+<!--
--- End diff --
`<#-- -->` is a freemarker comment:
http://freemarker.org/docs/dgui_template_overallstructure.html
`<!-- -->` is a XML/HTML comment.
This difference is important. Templates are processed by freemarker. So if
`<#-- -->` is used in a template file, generated code does not have the comment
block(`<#-- -->`). However, `<!-- -->` is used in it, generated code has the
comment block(`<!-- -->`). In this case, the generated code will have the
license header.
BTW, if template files are user visible(e.g. Tools > Templates > Select
Something > Open in editor), probably, we should not add the license header.
(we should add them to rat excludes.)
https://lists.apache.org/thread.html/43bec9e29901ef8d935c2f1515c2b7710c6a7e0b32657c3ddc1468c4@%3Cdev.netbeans.apache.org%3E
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
