[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215725#comment-16215725
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
matthiasblaesing opened a new pull request #181: [NETBEANS-54] Module Review
libs.osgi (followup)
URL: https://github.com/apache/incubator-netbeans/pull/181
Maven central does not hold the original netbeans artifact
osgi.cmpn-4.2, but a superset of that:
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.compendium</artifactId>
<version>4.2.0</version>
</dependency>
That artifact holds not only the compiled binaries, but also the
java sources in a subfolder "OSGI-OPT". To get the original netbeans
file, the jar is repacked and the folder is stripped. The resulting
zip is not identical to the original binary, but the difference is
in the zip structure, after expanding the original contents and the
new file are identical.
This PR is a followup for #104 which introduced a maven coordinate,
that can't be satisfied from maven central.
There are newer osgi compendium jar on maven central and it looks
as if at least 4.3.1 would also work, but updating libraries should be
a separate task from this cleanup task.
This approach was inspired by @vieiro who first came up with
building modified binaries for maven sources.
@geertjanw could you please have a look at this and see if it works for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
