[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216658#comment-16216658
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
vieiro commented on issue #172: [NETBEANS-54] Module Review
o.apache.xml.resolver
URL:
https://github.com/apache/incubator-netbeans/pull/172#issuecomment-338942929
You need a command-line "patch" program. I'm not sure how to install int in
Windows (I don't use Windows myself).
This opens an interesting issue. if we want to patch sources then we need
the "patch" command line program, i.e., we now depend on the "patch"
program.
Are we ready for this dependency?
2017-10-24 10:49 GMT+02:00 David Bolsover <notificati...@github.com>:
> Having problems with this..
>
> Build is failing with message:
>
> -prepare-patched-binary:
> [echo] Patching xml-resolver-1.2-sources.jar for Netbeans...
> [mkdir] Created dir: D:\incubator-netbeans\o.apache.xml.resolver\build\
> external-patch\sources
> [unzip] Expanding:
D:\incubator-netbeans\o.apache.xml.resolver\external\xml-resolver-1.2-sources.jar
> into D:\incubator-netbeans\o.apache.xml.resolver\build\
> external-patch\sources
> [nbmerge] Failed to build target: all-o.apache.xml.resolver
>
> BUILD FAILED
> D:\incubator-netbeans\nbbuild\build.xml:425: The following error occurred
> while executing this line:
> D:\incubator-netbeans\nbbuild\build.xml:420: The following error occurred
> while executing this line:
> D:\incubator-netbeans\nbbuild\build.xml:467: The following error occurred
> while executing this line:
> D:\incubator-netbeans\o.apache.xml.resolver\build.xml:47:
> java.io.IOException: Cannot run program "patch" (in directory
>
"D:\incubator-netbeans\o.apache.xml.resolver\build\external-patch\sources"):
> CreateProcess error=2, The system cannot find the file specified
> at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
> at java.lang.Runtime.exec(Runtime.java:620)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-netbeans/pull/172#issuecomment-338919992>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AAibrHIyIHCFWMfT8w7EejsDbGjXId6Oks5svaSMgaJpZM4QBo_->
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
