[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216824#comment-16216824
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
geertjanw closed pull request #187: [NETBEANS-54] adding schema2beans test data
to Rat exceptions
URL: https://github.com/apache/incubator-netbeans/pull/187
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index bb109b29c..84448511b 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -1991,44 +1991,23 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude name="**/nbproject/private/**" /> <!--user-specific files
-->
<exclude name="**/src/META-INF/**" /> <!--no degree of
creativity-->
<exclude name="*/build/**" />
- <exclude name="api.search/test/unit/data/textFiles/utf8file.txt"
/> <!--test data-->
- <exclude
name="api.search/test/unit/src/org/netbeans/modules/search/data/**" /> <!--test
data-->
+ <exclude name="*/test/unit/data/**" />
+ <exclude name="*/test/qa-functional/data/**" />
<exclude
name="beans/src/org/netbeans/modules/beans/resources/templates/*.template" />
<!--license would be visible when users edit the templates inside their IDE-->
<exclude
name="css.editor/src/org/netbeans/modules/css/resources/CascadeStyleSheet.css.template"
/> <!-- user visible template -->
<exclude
name="css.editor/src/org/netbeans/modules/css/resources/CssExample" /> <!--
user visible template -->
- <exclude name="css.editor/test/unit/data/testfiles/**" />
<!--simple files for testing-->
<exclude name="css.editor/todo" /> <!-- no degree of creativity -->
- <exclude name="css.lib/test/unit/data/**" /> <!--test data-->
- <exclude
name="css.prep/test/qa-functional/data/css_prep/public_html/**" /> <!--simple
files for testing-->
- <exclude name="css.prep/test/unit/data/testFiles/test.less" />
<!--simple file forss testing-->
- <exclude
name="css.prep/test/unit/data/testFiles/testIssue227676.scss" /> <!--simple
file for testing-->
- <exclude name="css.prep/test/unit/data/testProject/public_html/*"
/> <!--simple files for testing-->
<exclude
name="debugger.jpda/test/unit/src/org/netbeans/api/debugger/jpda/testapps/JspLineBreakpointApp.txt"
/> <!-- test data -->
- <exclude name="diff/test/unit/data/**" /> <!--test data-->
<exclude
name="diff/test/unit/src/org/netbeans/modules/diff/builtin/provider/*.txt" />
<!--test data-->
- <exclude
name="diff/test/unit/src/org/netbeans/modules/diff/builtin/visualizer/data/**"
/> <!--test data-->
- <exclude
name="editor.fold/test/unit/data/goldenfiles/hierarchy/update-hierarchy.folds"
/> <!--test data-->
- <exclude
name="editor.fold/test/unit/data/hierarchy/update-hierarchy.folds" /> <!--test
data-->
<exclude
name="editor.fold/test/unit/src/org/netbeans/modules/editor/fold/FoldContentReader.txt"
/> <!--test data-->
<exclude
name="editor.plain/src/org/netbeans/modules/editor/plain/resources/PlainTextExample"
/> <!--license would be visible to users in the Fonts/Colors settings-->
<exclude
name="editor.settings.storage/test/unit/src/org/netbeans/modules/editor/settings/storage/compatibility/p1/**"
/> <!--test data-->
- <exclude
name="extbrowser/test/unit/src/org/netbeans/modules/extbrowser/data/mac_defaults_*"
/> <!--test data-->
- <exclude name="form/test/unit/data/goldenfiles/*" /> <!--test
data-->
<exclude
name="hibernate/src/org/netbeans/modules/hibernate/resources/Hibernate*.xml" />
<!--template files-->
<exclude
name="hibernate/src/org/netbeans/modules/hibernate/resources/HibernateUtil.javax"
/> <!--template file-->
- <exclude name="html.lexer/test/unit/data/testfiles/*" /> <!--test
data-->
<exclude
name="hudson.subversion/test/unit/src/org/netbeans/modules/hudson/subversion/sample-entries-file"
/> <!--test data-->
- <exclude name="ide.kit/test/qa-functional/**/*.txt" /> <!-- test
data -->
<exclude
name="java.api.common/src/org/netbeans/modules/java/api/common/project/ui/customizer/vmo/gen/CommandLine.tokens"
/> <!--generated by ANTLR-->
- <exclude name="java.editor.base/test/unit/data/**" /> <!--test
data-->
<exclude
name="java.editor/src/org/netbeans/modules/java/editor/resources/JavaExample"
/> <!--no degree of creativity-->
- <exclude name="java.editor/test/qa-functional/data/**" /> <!--test
data-->
- <exclude name="java.editor/test/unit/data/**" /> <!--test data-->
<exclude
name="java.j2semodule/src/org/netbeans/modules/java/j2semodule/ui/resources/module-info.java.template"
/> <!--template file-->
- <exclude name="java.lexer/test/unit/data/testfiles/*" /> <!--test
data-->
- <exclude
name="javadoc/test/unit/data/docs_jdk14_ja/api/index-files/**" /> <!--test
data-->
- <exclude
name="javafx2.editor/test/unit/data/goldenfiles/org/netbeans/modules/javafx2/editor/completion/impl/**/*.out*"
/>
- <exclude
name="javafx2.editor/test/unit/data/org/netbeans/modules/javafx2/editor/**/*.fxml"
/>
<exclude name="javafx2.kit/release/VERSION.txt" /> <!--generated
file-->
<exclude
name="javafx2.project/src/org/netbeans/modules/javafx2/project/templates/**" />
<!--license would be visible when users edit the templates inside their IDE-->
<exclude name="javawebstart/AntTasks/build/**" /> <!-- generated
build files -->
@@ -2036,25 +2015,18 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude
name="languages.diff/src/org/netbeans/modules/languages/diff/DiffExample.diff"
/> <!--license would be visible to users in the Fonts/Colors settings-->
<exclude
name="languages.yaml/src/org/netbeans/modules/languages/yaml/*.yaml" />
<!--Files used in GUI as sample/starting point-->
<exclude
name="languages.yaml/src/org/netbeans/modules/languages/yaml/*.yml" />
<!--Files used in GUI as sample/starting point-->
- <exclude name="languages.yaml/test/unit/data/testfiles/*" />
<!--test data-->
- <exclude name="libs.freemarker/test/unit/data/**" /> <!--test
data-->
+ <exclude name="lib.uihandler/test/unit/src/**" /> <!--test data-->
<exclude
name="mercurial/src/org/netbeans/modules/mercurial/util/log*" /> <!-- user
templates for mercurial commits, etc. -->
- <exclude name="mercurial/test/qa-functional/data/files/**"/> <!--
qa test data -->
- <exclude name="mercurial/test/unit/data/**" /> <!-- unit test data
-->
<exclude name="nbbuild/netbeans/**" />
+ <exclude name="nbbuild/testuserdir/**" />
<exclude name="o.apache.tools.ant.module/release/VERSION.txt" />
<!--generated file-->
<exclude
name="o.apache.tools.ant.module/src/org/apache/tools/ant/module/resources/CustomTask_java"
/> <!-- user visible file template -->
<exclude
name="o.apache.tools.ant.module/src/org/apache/tools/ant/module/resources/Project.xml_"
/> <!-- user visible file template -->
- <exclude
name="o.apache.tools.ant.module/test/unit/data/**/*.properties" /> <!--test
data-->
- <exclude name="o.apache.tools.ant.module/test/unit/data/**/*.xml"
/> <!--test data-->
<exclude
name="options.editor/src/org/netbeans/modules/options/colors/AllLanguagesExample"
/> <!--no degree of creativitya-->
<exclude
name="options.editor/src/org/netbeans/modules/options/colors/HighlightingExample"
/> <!--no degree of creativitya-->
<exclude
name="options.editor/src/org/netbeans/modules/options/indentation/indentationExample"
/> <!--no degree of creativitya-->
- <exclude name="projectimport.eclipse.core/test/unit/data/**" />
<!--test data-->
<exclude
name="projectui/src/org/netbeans/modules/project/ui/resources/*-license.txt" />
<!--licenses-->
<exclude
name="projectui/src/org/netbeans/modules/project/ui/resources/license-default.txt"
/> <!--licenses-->
- <exclude name="projectuiapi/test/unit/data/*.txt" /> <!--test
data-->
- <exclude
name="projectuiapi/test/unit/src/org/netbeans/modules/project/uiapi/data/*.txt"
/> <!--test data-->
<exclude
name="selenium2.java/src/org/netbeans/modules/selenium2/java/SeleneseIT.java.template"
/> <!--template file-->
<exclude
name="spellchecker.dictionary_en/release/modules/dict/*.description" />
<!--Description Files-->
<exclude
name="spi.navigator/test/unit/src/org/netbeans/modules/navigator/resources/lastsel/file.lastsel_mime1"
/> <!--empty file-->
@@ -2062,13 +2034,6 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude
name="templates/src/org/netbeans/modules/templates/resources/userprop.txt" />
<!--no degree of creativity-->
<exclude
name="testng.ui/src/org/netbeans/modules/testng/ui/resources/*.template" />
<!--template files-->
<exclude
name="utilities/test/unit/src/org/netbeans/modules/openfile/resources/recent_files/*"
/> <!--test data-->
- <exclude
name="versioning.core/test/unit/data/workdir/root-test-versioned/**" />
<!--test data-->
- <exclude
name="versioning.core/test/unit/data/workdir/root-with-exclusions/**" />
<!--test data-->
- <exclude name="versioning.core/test/unit/data/workdir/root/a.txt"
/> <!--test data-->
- <exclude name="versioning.util/test/unit/data/historycache/*" />
<!--test data-->
- <exclude
name="versioning/test/unit/data/workdir/root-test-versioned/**" /> <!--test
data-->
- <exclude
name="versioning/test/unit/data/workdir/root-with-exclusions/**" /> <!--test
data-->
- <exclude name="versioning/test/unit/data/workdir/root/a.txt" />
<!--test data-->
<exclude
name="websvc.saas.api/src/org/netbeans/modules/websvc/saas/oauth/*.template" />
<!--template files-->
<exclude
name="websvc.saas.api/test/unit/src/org/netbeans/modules/websvc/saas/model/application.wadl"
/> <!--test data-->
<exclude
name="websvc.saas.api/test/unit/src/org/netbeans/modules/websvc/saas/util/rootGroup.xml"
/> <!--test data-->
@@ -2083,7 +2048,6 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude
name="xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/dummyProject/nbproject/private/tmpfile"
/> <!-- test data -->
<exclude
name="xml.text/src/org/netbeans/modules/xml/text/resources/DTDExample" /> <!--
GUI sample file to demonstrate syntax highlighting -->
<exclude
name="xml.text/src/org/netbeans/modules/xml/text/resources/XMLExample" /> <!--
GUI sample file to demonstrate syntax highlighting -->
- <exclude
name="xml.text/test/qa-functional/src/org/netbeans/modules/xml/text/**/data/**"
/> <!-- test data -->
<exclude
name="xml.tools/test/qa-functional/src/org/netbeans/modules/**/*.dtd" /> <!--
test data -->
<exclude
name="xml.tools/test/qa-functional/src/org/netbeans/modules/**/*.txt" /> <!--
test data -->
<exclude
name="xml.tools/test/qa-functional/src/org/netbeans/modules/**/*.xml" /> <!--
test data -->
@@ -2097,7 +2061,6 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude
name="xml/src/org/netbeans/modules/xml/resources/templates/*" /> <!-- template
files - tracked by https://issues.apache.org/jira/browse/NETBEANS-85 -->
<exclude
name="xml/test/unit/src/org/netbeans/modules/xml/resources/*" /> <!-- test data
-->
<exclude
name="xsl/src/org/netbeans/modules/xsl/resources/templates/stylesheet.xsl" />
<!-- Template for user - very limited degree of creativity -->
- <exclude
name="xsl/test/unit/src/org/netbeans/modules/xsl/utils/data/*" /> <!--test
data-->
</patternset>
<rat:report xmlns:rat="antlib:org.apache.rat.anttasks"
reportfile="build/rat-report.txt">
<rat:substringMatcher licenseFamilyCategory="w3c2"
licenseFamilyName="W3C Software and Document Notice and License">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
