[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218333#comment-16218333
 ] 

ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------

geertjanw closed pull request #191: [NETBEANS-54] Module Review swing.validation
URL: https://github.com/apache/incubator-netbeans/pull/191
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/swing.validation/arch.xml b/swing.validation/arch.xml
index 5268c8757..896c33ffd 100644
--- a/swing.validation/arch.xml
+++ b/swing.validation/arch.xml
@@ -50,7 +50,7 @@
  <answer id="arch-overall">
   <p>
    Provides a framework for adding user input validation to existing Swing
-   panels very simply.  See <a 
href="http://kenai.com/projects/simplevalidation/pages/Home";>the
+   panels very simply.  See <a 
href="https://github.com/timboudreau/simplevalidation/";>the
    Simple Validation</a> project for details.
    </p>
    <p>
@@ -160,7 +160,7 @@
 -->
  <answer id="arch-where">
   The source code for the Simple Validation project is at
-  <a 
href="http://kenai.com/projects/simplevalidation/pages/Home";>http://kenai.com/projects/simplevalidation/pages/Home</a>.
+  <a 
href="https://github.com/timboudreau/simplevalidation/";>https://github.com/timboudreau/simplevalidation/</a>.
   The adapters for dialog descriptors and wizards are in the module.
  </answer>
 
@@ -317,7 +317,7 @@
 -->
  <answer id="dep-non-nb">
   <p>
-   http://kenai.com/projects/simplevalidation/pages/Home
+   https://github.com/timboudreau/simplevalidation/
   </p>
  </answer>
 
diff --git a/swing.validation/external/ValidationAPI-license.txt 
b/swing.validation/external/ValidationAPI-license.txt
index 53da6f5d7..155288e2e 100644
--- a/swing.validation/external/ValidationAPI-license.txt
+++ b/swing.validation/external/ValidationAPI-license.txt
@@ -3,6 +3,7 @@ Version: 331
 License: CDDL-GPL-2-CP
 OSR: 11316
 Origin: Oracle (https://svn.kenai.com/svn/simplevalidation~src/trunk@331)
+       (same as: 
https://github.com/timboudreau/simplevalidation/tree/b26b94cc001a41ab9138496b11e2ae256a159ffd)
 Comment:  Provides utilities for adding input validation to Swing forms 
quickly and easily
 
 COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
diff --git a/swing.validation/nbproject/project.properties 
b/swing.validation/nbproject/project.properties
index 4eab392ef..3c8b5465f 100644
--- a/swing.validation/nbproject/project.properties
+++ b/swing.validation/nbproject/project.properties
@@ -18,6 +18,6 @@ is.autoload=true
 javac.source=1.6
 javac.compilerargs=-Xlint -Xlint:-serial
 javadoc.arch=${basedir}/arch.xml
-nbm.homepage=http://kenai.com/projects/simplevalidation/
+nbm.homepage=https://github.com/timboudreau/simplevalidation/
 nbm.module.author=Tim Boudreau
 release.external/ValidationAPI.jar=modules/ext/ValidationAPI.jar


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
>                 Key: NETBEANS-54
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-54
>             Project: NetBeans
>          Issue Type: Bug
>            Reporter: Bertrand Delacretaz
>              Labels: pull-request-available
>         Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to