[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219462#comment-16219462
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
matthiasblaesing commented on issue #117: [NETBEANS-54] Modeule Review
j2ee.persistence
URL:
https://github.com/apache/incubator-netbeans/pull/117#issuecomment-339460139
Ok - this still looks a bit chaotic:
- please squash the commits together into one - this gives a better overview
what was really changed:
https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
- rebase the changes onto master (build.xml is currently in flux, so you
need a recent version to get this mergeable)
- remove these lines from `.gitignore`:
```
/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_1_0.xsd
/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_2_0.xsd
/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_2_1.xsd
/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/persistence_1_0.xsd
/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/persistence_2_0.xsd
/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/persistence_2_1.xsd
```
- the "expand zip" part in `j2ee.persistence/build.xml` needs to be removed
(lines 25-29)
- the contents of the zip `orm*.xsd` and `persistence*.xsd` needs to placed
in `j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/`
(see the result of a normal build, the xsds can be found in the source)
- the whole external folder needs be removed, after the XSDs are moved into
the correct location
- Add rat exclusions to build.xml:
```
<exclude
name="j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/*.xsd"
/> <!-- XSDs for usage at runtime and code generation - the XSDs are not
modified, so covered by https://www.apache.org/legal/resolved.html#category-b
-->
<exclude
name="j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/*.xml"
/> <!-- user visible file template -->
<exclude
name="j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/jpacontroller/resources/*.txt"
/> <!-- user visible file template -->
```
This should do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
