[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235665#comment-16235665
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
matthiasblaesing closed pull request #210: [NETBEANS-54] Module Review
o.apache.commons.codec
URL: https://github.com/apache/incubator-netbeans/pull/210
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/o.apache.commons.codec/build.xml b/o.apache.commons.codec/build.xml
index af4316748..20f87dffa 100644
--- a/o.apache.commons.codec/build.xml
+++ b/o.apache.commons.codec/build.xml
@@ -23,7 +23,7 @@
<import file="../nbbuild/templates/projectized.xml"/>
<target name="jar">
<jar jarfile="${cluster}/${module.jar}">
- <zipfileset src="external/apache-commons-codec-1.3.jar"/>
+ <zipfileset src="external/commons-codec-1.3.jar"/>
<manifest>
<attribute name="Bundle-SymbolicName"
value="org.apache.commons.codec"/>
<attribute name="Bundle-Version" value="1.3.0"/>
diff --git a/o.apache.commons.codec/external/binaries-list
b/o.apache.commons.codec/external/binaries-list
index b34abc540..9caf2fac6 100644
--- a/o.apache.commons.codec/external/binaries-list
+++ b/o.apache.commons.codec/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-FD32786786E2ADB664D5ECC965DA47629DCA14BA apache-commons-codec-1.3.jar
+FD32786786E2ADB664D5ECC965DA47629DCA14BA commons-codec:commons-codec:1.3
diff --git
a/o.apache.commons.codec/external/org.apache.commons.codec-1.3.0-license.txt
b/o.apache.commons.codec/external/commons.codec-1.3-license.txt
similarity index 100%
rename from
o.apache.commons.codec/external/org.apache.commons.codec-1.3.0-license.txt
rename to o.apache.commons.codec/external/commons.codec-1.3-license.txt
diff --git a/o.apache.commons.codec/external/commons.codec-1.3-notice.txt
b/o.apache.commons.codec/external/commons.codec-1.3-notice.txt
new file mode 100644
index 000000000..7196130f7
--- /dev/null
+++ b/o.apache.commons.codec/external/commons.codec-1.3-notice.txt
@@ -0,0 +1,2 @@
+This product includes software developed by
+The Apache Software Foundation (http://www.apache.org/).
\ No newline at end of file
diff --git a/o.apache.commons.codec/nbproject/project.xml
b/o.apache.commons.codec/nbproject/project.xml
index 72f270a8e..19e85cb94 100644
--- a/o.apache.commons.codec/nbproject/project.xml
+++ b/o.apache.commons.codec/nbproject/project.xml
@@ -28,7 +28,7 @@
<public-packages/>
<class-path-extension>
<runtime-relative-path>org-apache-commons-codec.jar</runtime-relative-path>
-
<binary-origin>external/apache-commons-codec-1.3.jar</binary-origin>
+ <binary-origin>external/commons-codec-1.3.jar</binary-origin>
</class-path-extension>
</data>
</configuration>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Priority: Major
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
