[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238264#comment-16238264
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
matthiasblaesing closed pull request #233: [NETBEANS-54] Module Review
o.eclipse.core.runtime
URL: https://github.com/apache/incubator-netbeans/pull/233
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/o.eclipse.core.runtime/external/binaries-list
b/o.eclipse.core.runtime/external/binaries-list
index 071544d04..cb8539372 100644
--- a/o.eclipse.core.runtime/external/binaries-list
+++ b/o.eclipse.core.runtime/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-D2D2105B1E3C9E2FA6240AD088237A57590DDA8D
org.eclipse.core.runtime-3.7.0_nosignature.jar
+6658C235056134F7E86295E751129508802D71F2
org.eclipse.core:org.eclipse.core.runtime:3.7.0
diff --git a/o.eclipse.core.runtime/nbproject/project.properties
b/o.eclipse.core.runtime/nbproject/project.properties
index 611e0becf..dd023c945 100644
--- a/o.eclipse.core.runtime/nbproject/project.properties
+++ b/o.eclipse.core.runtime/nbproject/project.properties
@@ -14,6 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-release.external/org.eclipse.core.runtime-3.7.0_nosignature.jar=modules/org-eclipse-core-runtime.jar
+release.external/org.eclipse.core.runtime-3.7.0.jar=modules/org-eclipse-core-runtime.jar
is.autoload=true
nbm.module.author=Tomas Stupka
diff --git a/o.eclipse.core.runtime/nbproject/project.xml
b/o.eclipse.core.runtime/nbproject/project.xml
index 56ba189a0..908d3427c 100644
--- a/o.eclipse.core.runtime/nbproject/project.xml
+++ b/o.eclipse.core.runtime/nbproject/project.xml
@@ -76,7 +76,7 @@
</public-packages>
<class-path-extension>
<runtime-relative-path>org-eclipse-core-runtime.jar</runtime-relative-path>
-
<binary-origin>external/org.eclipse.core.runtime-3.7.0_nosignature.jar</binary-origin>
+
<binary-origin>external/org.eclipse.core.runtime-3.7.0.jar</binary-origin>
</class-path-extension>
</data>
</configuration>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Priority: Major
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
