[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239435#comment-16239435
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
geertjanw closed pull request #243: [NETBEANS-54] excluding specific files for
various reasons via Rat ex…
URL: https://github.com/apache/incubator-netbeans/pull/243
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 69ab0f773..225885912 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2021,6 +2021,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude
name="hibernate/src/org/netbeans/modules/hibernate/resources/Hibernate*.xml" />
<!--template files-->
<exclude
name="hibernate/src/org/netbeans/modules/hibernate/resources/HibernateUtil.javax"
/> <!--template file-->
<exclude
name="hudson.subversion/test/unit/src/org/netbeans/modules/hudson/subversion/sample-entries-file"
/> <!--test data-->
+ <exclude name="ide/launcher/macosx/NetBeansLauncher/ReadMe.rtf" />
<!--does not natively support comments-->
<exclude
name="j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/*.xsd"
/> <!-- XSDs for usage at runtime and code generation - the XSDs are not
modified, so covered by https://www.apache.org/legal/resolved.html#category-b
-->
<exclude
name="j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/*.xml"
/> <!-- user visible file template -->
<exclude
name="j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/jpacontroller/resources/*.txt"
/> <!-- user visible file template -->
@@ -2035,16 +2036,21 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude name="javafx2.kit/release/VERSION.txt" /> <!--generated
file-->
<exclude
name="javafx2.project/src/org/netbeans/modules/javafx2/project/templates/**" />
<!--license would be visible when users edit the templates inside their IDE-->
<exclude name="javawebstart/AntTasks/build/**" /> <!-- generated
build files -->
+ <exclude
name="jellytools.platform/src/org/netbeans/jellytools/version_info" /> <!--does
not natively support comments-->
<exclude
name="junit.ui/src/org/netbeans/modules/junit/ui/resources/*.template" />
<!--license would be visible when users edit the templates inside their IDE-->
<exclude
name="languages.diff/src/org/netbeans/modules/languages/diff/DiffExample.diff"
/> <!--license would be visible to users in the Fonts/Colors settings-->
<exclude
name="languages.yaml/src/org/netbeans/modules/languages/yaml/*.yaml" />
<!--Files used in GUI as sample/starting point-->
<exclude
name="languages.yaml/src/org/netbeans/modules/languages/yaml/*.yml" />
<!--Files used in GUI as sample/starting point-->
+ <exclude
name="lib.uihandler/src/org/netbeans/lib/uihandler/pubKey" /> <!--no degree of
creativity-->
<exclude name="lib.uihandler/test/unit/src/**" /> <!--test data-->
<exclude
name="maven.htmlui/src/org/netbeans/modules/maven/htmlui/UIDefaults" /> <!--
config file with no place for license header-->
<exclude
name="maven.indexer/external/NOTICE-patched-indexer-core-6.0.0" /> <!--no
degree of creativity-->
<exclude
name="mercurial/src/org/netbeans/modules/mercurial/util/log*" /> <!-- user
templates for mercurial commits, etc. -->
+ <exclude name="nbbuild/hudson/.hgmail-profiler" /> <!--no degree
of creativity-->
+ <exclude name="nbbuild/l10n.patterns" /> <!--no degree of
creativity-->
<exclude name="nbbuild/licenses/**" />
<exclude name="nbbuild/netbeans/**" />
+ <exclude name="nbbuild/tagref" /> <!--no degree of creativity-->
<exclude name="nbbuild/testuserdir/**" />
<exclude name="o.apache.tools.ant.module/release/VERSION.txt" />
<!--generated file-->
<exclude
name="o.apache.tools.ant.module/src/org/apache/tools/ant/module/resources/CustomTask_java"
/> <!-- user visible file template -->
@@ -2052,6 +2058,8 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude name="o.n.core/licenses/**" /> <!-- license files -->
<exclude
name="o.n.core/test/unit/src/org/netbeans/core/projects/cache/data/**" /> <!--
test data -->
<exclude
name="openide.nodes/test/unit/src/org/openide/nodes/data/**" /> <!-- test data
-->
+ <exclude
name="openide.util.ui/test/unit/src/org/openide/util/UtilitiesTranslateEmpty.txt"
/> <!-- license would cause tests to fail -->
+ <exclude
name="openide.util/test/unit/src/org/openide/util/LookupUsesRequestProcessorTest.resource"
/> <!-- license would cause tests to fail -->
<exclude
name="options.editor/src/org/netbeans/modules/options/colors/AllLanguagesExample"
/> <!--no degree of creativitya-->
<exclude
name="options.editor/src/org/netbeans/modules/options/colors/HighlightingExample"
/> <!--no degree of creativitya-->
<exclude
name="options.editor/src/org/netbeans/modules/options/indentation/indentationExample"
/> <!--no degree of creativitya-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
