[
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247010#comment-16247010
]
ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------
junichi11 closed pull request #255: [NETBEANS-54] Module Review api.templates
URL: https://github.com/apache/incubator-netbeans/pull/255
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml
b/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml
index 5bddc48f0..b508d10e4 100644
--- a/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml
+++ b/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml
@@ -1,24 +1,3 @@
-<!--
-
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-
--->
-
print('<?xml version="1.0"?>');
print('<root>');
print(' Žluťoučký kůň skákal přes čtvero mezí.');
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index db1024677..11c14a173 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2005,9 +2005,10 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude name="**/package-list" /> <!--no degree of creativity-->
<exclude name="*/test/unit/data/**" /> <!--would cause tests to
fail-->
<exclude name="*/test/qa-functional/data/**" /> <!--would cause
tests to fail-->
- <exclude
name="autoupdate.services/test/unit/src/org/netbeans/modules/autoupdate/updateprovider/data/**"
/> <!-- test data -->
<exclude
name="api.search/test/unit/src/org/netbeans/modules/search/data/**" /> <!--test
data-->
+ <exclude
name="api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml" />
<!--test data-->
<exclude
name="apisupport.ant/src/org/netbeans/modules/apisupport/project/resources/license-*.txt"
/> <!--template file-->
+ <exclude
name="autoupdate.services/test/unit/src/org/netbeans/modules/autoupdate/updateprovider/data/**"
/> <!-- test data -->
<exclude
name="beans/src/org/netbeans/modules/beans/resources/templates/*.template" />
<!--license would be visible when users edit the templates inside their IDE-->
<exclude
name="css.editor/src/org/netbeans/modules/css/resources/CascadeStyleSheet.css.template"
/> <!-- user visible template -->
<exclude
name="css.editor/src/org/netbeans/modules/css/resources/CssExample" /> <!--
user visible template -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
> Issue Type: Bug
> Reporter: Bertrand Delacretaz
> Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip,
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code
> donation, my understanding is that not all files found in that zip are
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are
> donated "excluding any third-party and separately licensed material contained
> within the Code File".
> I don't think we can consider that code ready to release as is, due to the
> uncertainty that this creates w.r.t to which files are donated and which are
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and
> separately licensed material". How such files are identified needs to be
> defined and documented, either in scripts under version control or as a set
> of rules. The review process must be documented and traceable, so that we can
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/ -
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
