[ 
https://issues.apache.org/jira/browse/NIFI-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703116#comment-14703116
 ] 

Matt Gilman commented on NIFI-864:
----------------------------------

[~JPercivall] Patch looks good. A couple minor things to address.

1) Looks like you updated the LICENSE and NOTICE file in nifi-assembly. This is 
good but you also need to do this in nifi-image-nar. Basically anywhere we are 
bundling these dependencies. We need to put them in nifi-assembly because we 
are bundling these dependency transitively through your NAR.

2) The MetadataWrapper class you've created could be replaced with the use of 
the ObjectHolder in nifi-utils. This obviously isn't critical, just FYI.

> Create a NAR for handling images
> --------------------------------
>
>                 Key: NIFI-864
>                 URL: https://issues.apache.org/jira/browse/NIFI-864
>             Project: Apache NiFi
>          Issue Type: New Feature
>    Affects Versions: 0.3.0
>            Reporter: Joseph Percivall
>            Priority: Minor
>         Attachments: nifi-864.patch
>
>
> It is useful to be able to do image related manipulation in dataflows.  
> Create a new nifi-image-bundle which will start out by having two processors. 
>  One for extracting image metadata and another for altering the size of the 
> image.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to