[ 
https://issues.apache.org/jira/browse/NIFI-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704042#comment-14704042
 ] 

Matt Gilman commented on NIFI-725:
----------------------------------

[~danbress] I hadn't thought about adding nifi-api as a provided dependency to 
the maven plugin. I guess the dependencies of the artifact being built are 
available to the plugin itself at build time (or runtime from the plugins 
perspective). This seems like a promising approach.

It probably makes sense to move the maven plugin out of the nifi repository [1] 
and into the nifi-maven repository [2]. 

I'm not quite sure about the extract or generate index plugins and whether we 
want that driven by the nifi build or the nifi-site build. The only part of it 
that concerns me though is knowing which artifacts contained documented 
components. It would be nice if we didn't have to brute force it.

[1] https://git-wip-us.apache.org/repos/asf/nifi.git
[2] https://git-wip-us.apache.org/repos/asf/nifi-maven.git

> Refactor when documentation is generated
> ----------------------------------------
>
>                 Key: NIFI-725
>                 URL: https://issues.apache.org/jira/browse/NIFI-725
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework, Documentation & Website
>    Affects Versions: 0.1.0
>            Reporter: Dan Bress
>            Assignee: Dan Bress
>            Priority: Minor
>
> Currently the DocGenerator, which generates all of our 
> Processor/ReportingTask/ControllerService documentation, is invoked directly 
> from the 
> [NiFi|https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-runtime/src/main/java/org/apache/nifi/NiFi.java#L123]
>  class in the runtime project.
> Invoking the DocGenerator directly from the runtime hamstrings what libraries 
> the DocGenerator can use, because the runtime project should have the least 
> number of dependencies possible, and it currently depends on the 
> documentation library.
> I'm proposing that we find a new way/place to invoke documentation generation 
> such that it may bring in whatever dependencies it needs.
> The first dependency it needs is on nifi-framework-core 
> [ReflectionUtils|https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/ReflectionUtils.java],
>  which would let us [this 
> copy|https://github.com/apache/incubator-nifi/blob/NIFI-632/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/util/ReflectionUtils.java]
>  of that class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to