[ 
https://issues.apache.org/jira/browse/NIFI-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706578#comment-14706578
 ] 

Dan Bress commented on NIFI-293:
--------------------------------

[~markap14]
PutSQL processor supports "DELETE" as well?
# Again from a user perspective this is a little confusing to me.  Having a 
processor called "Put" that actually deletes something.
# I don't see any reference in the code(PutSQL or ConvertJSONToSQL) to delete 
statements
# I don't see any reference in the documentation to delete statements

I understand the issues related to renaming something that has been released.  
Maybe we could copy ExecuteSQL.java to SelectSQL.java and deprecate ExecuteSQL? 
 Or consider doing this when the NiFi app it's self supports deprecated 
components(NIFI-391).  Is there plans to expand the functionality of ExecuteSQL 
beyond just SELECT statements?

[[email protected]] [~markap14]
My issue with the Alias idea Ryan proposed is I wouldn't want there to be 
multiple processors a user can pick that are exactly the same thing.  To me 
this would just add to the confusion.
If Mark's proposal is that under the covers and in the flow.xml the processor 
is known as "org.apache.nifi.ExecuteSQL" but in every way that it is presented 
to the user it is seen as "org.apache.nifi.SelectSQL", I am OK with that.  
EXCEPT I think this ends up being a massive change to do correctly.  UI, 
Logging, Documentation all would have to be updated.

@Joe Witt
I agree the tags definitely help If I am coming from the perspective of "how do 
I do a execute select sql statements in NiFi?", I have no issues with that work 
flow.  However, once I become aware of "ExecuteSQL" my first thought is that I 
should be able to use this processor to execute any SQL statement.  Especially 
If I don't know about "PutSQL" at this point.

I'm not trying to seem like I am massively hung up on this, I just think it 
could be confusing to users and I'd rather sort it out sooner rather than later.

> Add a JDBC Processor for executing arbitrary SQL queries
> --------------------------------------------------------
>
>                 Key: NIFI-293
>                 URL: https://issues.apache.org/jira/browse/NIFI-293
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Ricky Saltzer
>         Attachments: AvroWriter.java
>
>
> This could be very useful for a variety of tasks, such as updating a value in 
> a PostgreSQL table, or adding a new partition to Hive. 
> Ideally, SQL commands could be generated using the NiFi expression language 
> using FlowFile attributes. 
> The processor should as generic as possible so that any of the popular JDBC 
> drivers can be used (e.g. PostgreSQL, Hive, Impala). 
> I'm still new to how processors are architected, but it seems that using a 
> pre-defined service in the _services.xml_ file (like the distributed map 
> cache) would be the most efficient way to share a connection pool across 
> multiple JDBC processors. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to