[
https://issues.apache.org/jira/browse/NIFI-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Bende updated NIFI-884:
-----------------------------
Attachment: NIFI-884.patch
Patch moves the deletion of the pid file to happen after a successful shutdown
has occurred.
To test this you can do the following:
* build with the patch and start nifi as normal
* run nifi.sh stop but immediately do a ctrl+c to exit the shutdown process
* there should still be a nifi.pid in the bin directory
* run nifi.sh start it should identify that there is already a running instance
and not start a new one.
> bin/nifi.sh not detecting already running instances
> ---------------------------------------------------
>
> Key: NIFI-884
> URL: https://issues.apache.org/jira/browse/NIFI-884
> Project: Apache NiFi
> Issue Type: Bug
> Components: Configuration, Core Framework
> Reporter: Joseph Witt
> Assignee: Bryan Bende
> Priority: Critical
> Fix For: 0.3.0
>
> Attachments: NIFI-884.patch
>
>
> i tried to stop nifi with bin/nifi.sh stop
> It was taking too long with these statements:
> {noformat}
> [joe@dev111 nifi-0.3.0-SNAPSHOT]$ bin/nifi.sh restart
> Java home: /usr/java/latest/
> NiFi home:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT
> Bootstrap Config File:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/bootstrap.conf
> 2015-08-21 13:40:07,783 INFO [main] org.apache.nifi.bootstrap.Command Apache
> NiFi has accepted the Shutdown Command and is shutting down now
> 2015-08-21 13:40:07,814 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:40:09,821 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:40:11,828 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:40:13,836 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:40:15,844 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:40:17,852 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:40:19,861 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:40:21,869 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> ^C^C
> {noformat}
> So then i ran this command again
> {noformat}
> [joe@dev111 nifi-0.3.0-SNAPSHOT]$ bin/nifi.sh restart
> Java home: /usr/java/latest/
> NiFi home:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT
> Bootstrap Config File:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/bootstrap.conf
> 2015-08-21 13:40:32,294 INFO [main] org.apache.nifi.bootstrap.Command Apache
> NiFi is not currently running
> Java home: /usr/java/latest/
> NiFi home:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT
> Bootstrap Config File:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/bootstrap.conf
> 2015-08-21 13:40:35,729 INFO [main] org.apache.nifi.bootstrap.Command
> Starting Apache NiFi...
> 2015-08-21 13:40:35,731 INFO [main] org.apache.nifi.bootstrap.Command Working
> Directory:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT
> 2015-08-21 13:40:35,733 INFO [main] org.apache.nifi.bootstrap.Command
> Command: /usr/java/latest/bin/java -classpath
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./conf:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/logback-core-1.1.3.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/slf4j-api-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-runtime-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-api-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-properties-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/log4j-over-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-nar-utils-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/jul-to-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/jcl-over-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/logback-classic-1.1.3.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-documentation-0.3.0-SNAPSHOT.jar
> -Djava.net.preferIPv4Stack=true -Dsun.net.http.allowRestrictedHeaders=true
> -Djava.protocol.handler.pkgs=sun.net.www.protocol
> -Dorg.apache.jasper.compiler.disablejsr199=true -Xmx512m
> -Djava.awt.headless=true -Xms512m
> -Dnifi.properties.file.path=/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./conf/nifi.properties
> -Dnifi.bootstrap.listen.port=60376 -Dapp=NiFi org.apache.nifi.NiFi
> {noformat}
> And I thought hmm i better check ps to see if nifi was still running before.
> So i got this
> {noformat}
> [joe@dev111 nifi-0.3.0-SNAPSHOT]$ ps -ef | grep nifi
> joe 1584 1 0 13:21 pts/0 00:00:00 /bin/sh bin/nifi.sh restart
> joe 1586 1584 0 13:21 pts/0 00:00:03 /usr/java/latest//bin/java
> -cp
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/lib/bootstrap/*
> -Xms12m -Xmx24m
> -Dorg.apache.nifi.bootstrap.config.file=/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/bootstrap.conf
> org.apache.nifi.bootstrap.RunNiFi start
> joe 1603 1586 99 13:21 pts/0 00:19:31 /usr/java/latest/bin/java
> -classpath
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./conf:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/logback-core-1.1.3.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/slf4j-api-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-runtime-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-api-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-properties-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/log4j-over-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-nar-utils-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/jul-to-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/jcl-over-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/logback-classic-1.1.3.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-documentation-0.3.0-SNAPSHOT.jar
> -Djava.net.preferIPv4Stack=true -Dsun.net.http.allowRestrictedHeaders=true
> -Djava.protocol.handler.pkgs=sun.net.www.protocol
> -Dorg.apache.jasper.compiler.disablejsr199=true -Xmx512m
> -Djava.awt.headless=true -Xms512m
> -Dnifi.properties.file.path=/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./conf/nifi.properties
> -Dnifi.bootstrap.listen.port=42211 -Dapp=NiFi org.apache.nifi.NiFi
> joe 3455 1 0 13:40 pts/0 00:00:00 /bin/sh bin/nifi.sh restart
> joe 3458 3455 6 13:40 pts/0 00:00:00 /usr/java/latest//bin/java
> -cp
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/lib/bootstrap/*
> -Xms12m -Xmx24m
> -Dorg.apache.nifi.bootstrap.config.file=/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/bootstrap.conf
> org.apache.nifi.bootstrap.RunNiFi start
> joe 3485 3458 99 13:40 pts/0 00:00:10 /usr/java/latest/bin/java
> -classpath
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./conf:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/logback-core-1.1.3.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/slf4j-api-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-runtime-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-api-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-properties-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/log4j-over-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-nar-utils-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/jul-to-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/jcl-over-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/logback-classic-1.1.3.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-documentation-0.3.0-SNAPSHOT.jar
> -Djava.net.preferIPv4Stack=true -Dsun.net.http.allowRestrictedHeaders=true
> -Djava.protocol.handler.pkgs=sun.net.www.protocol
> -Dorg.apache.jasper.compiler.disablejsr199=true -Xmx512m
> -Djava.awt.headless=true -Xms512m
> -Dnifi.properties.file.path=/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./conf/nifi.properties
> -Dnifi.bootstrap.listen.port=60376 -Dapp=NiFi org.apache.nifi.NiFi
> joe 3532 3746 0 13:40 pts/0 00:00:00 grep --color=auto nifi
> {noformat}
> So then i stopped nifi then checked ps again and got this
> {noformat}
> [joe@dev111 nifi-0.3.0-SNAPSHOT]$ bin/nifi.sh stop
> Java home: /usr/java/latest/
> NiFi home:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT
> Bootstrap Config File:
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/bootstrap.conf
> 2015-08-21 13:41:04,533 INFO [main] org.apache.nifi.bootstrap.Command Apache
> NiFi has accepted the Shutdown Command and is shutting down now
> 2015-08-21 13:41:04,548 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:06,556 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:08,564 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:10,572 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:12,579 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:14,587 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:16,595 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:18,604 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:20,613 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:22,620 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:24,628 INFO [main] org.apache.nifi.bootstrap.Command Waiting
> for Apache NiFi to finish shutting down...
> 2015-08-21 13:41:24,635 WARN [main] org.apache.nifi.bootstrap.Command NiFi
> has not finished shutting down after 20 seconds. Killing process.
> 2015-08-21 13:41:24,645 INFO [main] org.apache.nifi.bootstrap.Command NiFi
> has finished shutting down.
> [joe@dev111 nifi-0.3.0-SNAPSHOT]$ ps -ef | grep nifi
> joe 1584 1 0 13:21 pts/0 00:00:00 /bin/sh bin/nifi.sh restart
> joe 1586 1584 0 13:21 pts/0 00:00:03 /usr/java/latest//bin/java
> -cp
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/lib/bootstrap/*
> -Xms12m -Xmx24m
> -Dorg.apache.nifi.bootstrap.config.file=/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/conf/bootstrap.conf
> org.apache.nifi.bootstrap.RunNiFi start
> joe 1603 1586 99 13:21 pts/0 00:19:31 /usr/java/latest/bin/java
> -classpath
> /development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./conf:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/logback-core-1.1.3.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/slf4j-api-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-runtime-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-api-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-properties-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/log4j-over-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-nar-utils-0.3.0-SNAPSHOT.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/jul-to-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/jcl-over-slf4j-1.7.12.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/logback-classic-1.1.3.jar:/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./lib/nifi-documentation-0.3.0-SNAPSHOT.jar
> -Djava.net.preferIPv4Stack=true -Dsun.net.http.allowRestrictedHeaders=true
> -Djava.protocol.handler.pkgs=sun.net.www.protocol
> -Dorg.apache.jasper.compiler.disablejsr199=true -Xmx512m
> -Djava.awt.headless=true -Xms512m
> -Dnifi.properties.file.path=/development/apache-nifi/nifi.git/nifi-assembly/target/nifi-0.3.0-SNAPSHOT-bin/nifi-0.3.0-SNAPSHOT/./conf/nifi.properties
> -Dnifi.bootstrap.listen.port=42211 -Dapp=NiFi org.apache.nifi.NiFi
> joe 3700 3746 0 13:41 pts/0 00:00:00 grep --color=auto nifi
> {noformat}
> Seems like it can easily lose track of whether a nifi instance is already
> running or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
