Brandon DeVries created NIFI-920:
------------------------------------

             Summary: UnpackContent can continuously rollback on 
java.nio.InvalidPathException
                 Key: NIFI-920
                 URL: https://issues.apache.org/jira/browse/NIFI-920
             Project: Apache NiFi
          Issue Type: Bug
            Reporter: Brandon DeVries
            Priority: Minor


In UnpackContent, file.toPath() is called without catching 
java.nio.file.InvalidPathException:

https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java#L265#L266

https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java#L316#L318

This bubbles up out of the processor and causes a rollback, instead of simply 
failing the file in the processor.  

This could be fixed in each "Unpacker" implementation (possibly by catching and 
wrapping in a ProcessException), or the catch in the OnTrigger method here:

https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java#L238

... could simply be changed to "catch (final ProcessException | 
InvalidPathException e)".  Whoever implements the fix can think that all the 
way through.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to