[
https://issues.apache.org/jira/browse/NIFI-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768914#comment-14768914
]
Mark Payne commented on NIFI-919:
---------------------------------
[~bende] - Just a few comments from doing a code review:
- Capability description doesn't have a space between the last word of first
line & first word of second line (i know, already nit-picking ;-) )
- Properties that set Allowable Values don't really need to have validators set.
- OUTPUT_SIZE should probably use a POSITIVE_INTEGER_VALIDATOR, rather than an
INTEGER_VALIDATOR.
- I'm not super familiar with the Avro API, so it's not obvious to me what
would happen if you pass in a non-avro FlowFile? Will a ProcessException get
thrown and the file routed to failure? Will the session be rolled back? Will be
considered success and nothing routed to the splits relationship? Ideally, I
think we would see that go to failure and have a unit test to verify.
Aside from those few little suggestions, it looks great. Excellent unit test
coverage!
> Support Splitting Avro Files
> ----------------------------
>
> Key: NIFI-919
> URL: https://issues.apache.org/jira/browse/NIFI-919
> Project: Apache NiFi
> Issue Type: New Feature
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: NIFI-919-2.patch, NIFI-919.patch
>
>
> Provide a processor that splits an Avro file into multiple smaller files.
> Would be nice to have a configurable batch size so a user could produce
> single record files and also multi-record files of smaller size than the
> original. Also consider making the output format configurable, data file vs
> bare record.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
