[
https://issues.apache.org/jira/browse/NIFI-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950895#comment-14950895
]
Aldrin Piri commented on NIFI-673:
----------------------------------
-1. Not sure if your second patch was incorrect, but here are the observations
I had after applying each in order:
Completion strategy and move destination dir not currently included in the
properties for FetchSFTP from FetchFileTransfer. Not sure if these were
removed for being incorrect or forgotten about when corrected. Commit log
mentions adding these to Fetch but the actual patch only adds them to
FetchFileTransfer.
Delete_Original in FetchSFTP is no longer used but is still listed as a property
FetchSFTP makes use of many of the SFTPTransfer properties, but
FetchFileTransfer has its own for several inclusive of hostname, port. This is
confusing and happens to work within the onTrigger of FetchFileTransfer due to
the equivalent descriptors having the same name in both places. Would prefer
to see a convergence of all these properties for consistency.
ListFileTransfer needs to add a <protocol>.remote.port in addition to host.
Documentation should mention the possibility of data duplication. We commit
the file transfer but may not move/delete as specified for the condition you
outline in the code comments.
Does it make sense to have the user that did the listing also get added as an
attribute (could potentially see routing/filtering benefits based on user in
both List and Fetch)? On the one hand it would be nice as the listing is
possibly dependent on the user accessing it, but this falls flat as there is
not a way to specify the associated password via attribute and EL. Ever been
consideration of using sensitive properties for an attribute? Maybe it's
strictly intra-system?
Created an SFTP server and core behavior was as anticipated in its current
implementation, would need to review additional patch addressing above listed
issues.
> Create ListSFTP, FetchSFTP Processors
> -------------------------------------
>
> Key: NIFI-673
> URL: https://issues.apache.org/jira/browse/NIFI-673
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 0.4.0
>
> Attachments:
> 0001-NIFI-673-Initial-implementation-of-ListSFTP-FetchSFT.patch,
> 0002-NIFI-673-Added-Completion-Strategy-to-FetchSFTP.patch
>
>
> This will allow us to pull a listing from a single primary node and then
> distribute the work of pulling and processing the data across the cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
