[ 
https://issues.apache.org/jira/browse/NIFI-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964311#comment-14964311
 ] 

ASF subversion and git services commented on NIFI-1046:
-------------------------------------------------------

Commit 9aa716b0592bfd3552880b4d0042db499307f778 in nifi's branch 
refs/heads/master from [~_alexm]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9aa716b ]

NIFI-1046 shell clean up: quoting prevents globbing & word splitting.

Ignoring the unquoted array expansions on L188/190; suspect they ought to be 
quoted per [SC2068](https://github.com/koalaman/shellcheck/wiki/SC2068), but 
need to confirm desired arguments.

Reviewed by Tony Kurc ([email protected])


> clean up shell scripts
> ----------------------
>
>                 Key: NIFI-1046
>                 URL: https://issues.apache.org/jira/browse/NIFI-1046
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 0.3.0
>            Reporter: Alex Moundalexis
>            Assignee: Tony Kurc
>            Priority: Minor
>
> The stock shell script that ships with NiFi has a few areas that diverge from 
> best practices.
> Will propose some suggestions, please assign to me.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to