[ 
https://issues.apache.org/jira/browse/NIFI-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969296#comment-14969296
 ] 

ASF GitHub Bot commented on NIFI-987:
-------------------------------------

Github user rickysaltzer commented on the pull request:

    https://github.com/apache/nifi/pull/91#issuecomment-150260104
  
    @bbende I updated the review with a different approach to sending events. 
After I started doing a lot of random disconnect testing, it appeared that the 
`RiemannBatchClient` had some really odd behavior when it came to detecting a 
down connection. Instead of using that, I'm using the regular `RiemannClient` 
and batching them together myself. This way I can call the `deref()` on the 
`IPromise` in order to detect connection failures, or timeouts. 
    
    If the connection drops while sending events, the processor will `yield()` 
and attempt to re-connect on the next trigger until it can do so successfully. 
I also added a test (`testFailedDeref`) to verify that this works, as well as 
tested it internally with both `TCP` and `UDP`. 


> Add Processor for Writing Events to Riemann
> -------------------------------------------
>
>                 Key: NIFI-987
>                 URL: https://issues.apache.org/jira/browse/NIFI-987
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>         Attachments: Sample Riemann Dataflow .png
>
>
> Riemann (http://riemann.io) is a new framework for monitoring distributed 
> systems. It's particular useful for sending ad-hoc events such as, heartbeats 
> and metrics. It would be nice if NiFi had a PutRiemann processor for writing 
> events using the NiFi expression language.
> A simple use case would be a data flow that repeatedly checks specific 
> services over TCP, HTTP, etc and checks into Riemann. Another example would 
> be detecting a blip in events coming down a stream using a simple event 
> heartbeat mechanism. I'll post a couple visuals to help make these examples 
> more concrete.
> I have an initial PutRiemann processor made. I will post the patch via a 
> Github pull request later today.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to