[
https://issues.apache.org/jira/browse/NIFI-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990526#comment-14990526
]
Toivo Adams commented on NIFI-1106:
-----------------------------------
Thanks for the patch.
I am little bit confused.
May be its better to change TestConvertAvroToJSON method
testMultipleAvroMessagesContainerNone()
and use System.lineSeparator() instead of “\n”
In patch you fixed ConvertAvroToJSON in the way it doesn’t use use
System.lineSeparator() anymore.
This works also, but shouldn’t we use System.lineSeparator() instead of „\n“
Thanks
Toivo
> Fix TestConvertAvroToJson#
> --------------------------
>
> Key: NIFI-1106
> URL: https://issues.apache.org/jira/browse/NIFI-1106
> Project: Apache NiFi
> Issue Type: Test
> Components: Core Framework
> Environment: Windows7
> Reporter: Joe Skora
> Assignee: Joe Skora
> Priority: Trivial
> Labels: avro, test, windows7
> Attachments: NIFI-1106.000.patch
>
>
> Fix TestConvertAvroToJSON#testMultipleAvroMessagesContainerNone test. Test
> succeeds on Linux but fails on Windows, likely due to line termination issues.
> (from dev@nifi list)
> http://apache-nifi-developer-list.39713.n7.nabble.com/Avro-tests-are-broken-on-Windows-tp3538p3544.html
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.nifi.processors.avro.TestConvertAvroToJSON
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.421 sec
> <<< FAILURE! - in org.apache.nifi.processors.avro.TestConvertAvroToJSON
> testMultipleAvroMessagesContainerNone(org.apache.nifi.processors.avro.TestConvertAvroToJSON)
> Time elapsed: 0.01 sec <<< FAILURE!
> org.junit.ComparisonFailure: expected:<...vorite_color": null}[]
> {"name": "George", ...> but was:<...vorite_color": null}[
> ]
> {"name": "George", ...>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.nifi.util.MockFlowFile.assertContentEquals(MockFlowFile.java:232)
> at
> org.apache.nifi.util.MockFlowFile.assertContentEquals(MockFlowFile.java:227)
> at
> org.apache.nifi.util.MockFlowFile.assertContentEquals(MockFlowFile.java:223)
> at
> org.apache.nifi.processors.avro.TestConvertAvroToJSON.testMultipleAvroMessagesContainerNone(TestConvertAvroToJSON.java:127)
> Running org.apache.nifi.processors.avro.TestExtractAvroMetadata
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.14 sec -
> in org.apache.nifi.processors.avro.TestExtractAvroMetadata
> Running org.apache.nifi.processors.avro.TestSplitAvro
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.304 sec -
> in org.apache.nifi.processors.avro.TestSplitAvro
> Results :
> Failed tests:
> TestConvertAvroToJSON.testMultipleAvroMessagesContainerNone:127
> expected:<...vorite_color": null}[]
> {"name": "George", ...> but was:<...vorite_color": null}[
> ]
> {"name": "George", ...>
> Tests run: 23, Failures: 1, Errors: 0, Skipped: 0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
