[
https://issues.apache.org/jira/browse/NIFI-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006103#comment-15006103
]
Joseph Witt commented on NIFI-1165:
-----------------------------------
I think to Tony's point (and mine) if these are now causing failures again
having been un-ignored then we better be darn sure the reason they were ignored
is actually fixed OR we need to ignore them. The key here was to simply fix
the bad relationship. Not the tests. So in fixing a simple thing let's not
make a hard thing. Anway, if you are sure the tests are working now on all
platforms we need them to then great. That is Win/Lin/OSX basically.
If we're not sure they're good across the board (for reals) then let's just
stick to the intent of this ticket and focus on fixing all the various @Ignored
tests on other tickets. 0.4.0 needs to close down and we have to factor in
reviewer time. All changes from here need to be 0.4.0 related so we can ensure
dev and reviewer and then testing time from the community helps us get to 040.
> Master Build Fails on Windows
> -----------------------------
>
> Key: NIFI-1165
> URL: https://issues.apache.org/jira/browse/NIFI-1165
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Priority: Blocker
> Fix For: 0.4.0
>
>
> I tested with two separate Windows 8 machines and get the same errors when
> building master. There are errors in PutHDFSTest, TestRouteText and
> TestTailFile
> PutHDFSTest fails on lines 186 and 198.
> The output for the TestRouteText and TestTailFile:
> TestRouteText.testJson:655 expected:<7> but was:<0>
> TestRouteText.testXml:691 expected:<1> but was:<0>
> TestTailFile.setup:61 null
> TestTailFile.setup:61 null
> TestTailFile.setup:61 null
> TestTailFile.setup:61 null
> TestTailFile.setup:61 null
> TestTailFile.setup:61 null
> TestTailFile.testRolloverAfterHavingReadAllData:277 expected:<2> but was:<0>
> TestTailFile.setup:61 null
> TestTailFile.setup:61 null
> TestTailFile.setup:61 null
> TestHDFS is failing due to: "java.io.IOException: Could not locate executable
> null\bin\winutils.exe in the Hadoop binaries."
> TestRouteText is actually failing due to attempting to take into account
> Windows by using "System.lineSeparator()" when traversing a file that is
> checked into git using "\n" line separators.
> TestTailFile I believe is failing due to the processor holding a lock on the
> file while the file is trying to be rolled over. In order to manually test
> it, I ran NiFi and started tailing a file. When I tried to rename it (like a
> server rolling over a file would) it told me it was in use by Java.
> I already have a fix for TestRouteText, Oleg and I are working on HDFS, and
> Mark is working on TailFile
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
