[ 
https://issues.apache.org/jira/browse/NIFI-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032340#comment-15032340
 ] 

Mark Payne commented on NIFI-1225:
----------------------------------

In the .000 patch, I see the following snippet added:

{code}
+                        if (userMetadata.size() > 0) {
+                            StringBuilder userMetaBldr = new StringBuilder();
+                            for (String userKey : userMetadata.keySet()) {
+                                
userMetaBldr.append(userKey).append("=").append(userMetadata.get(userKey));
+                            }
+                            attributes.put(S3_USERMETA_ATTR_KEY, 
userMetaBldr.toString());
                         }
{code}

If there are multiple metadata keys, this is going to concatenate them together 
without any sort of delimiter. E.g., if we have the values {key1=value1, 
key2=value2} this will produce: key1=value1key2=value2

Perhaps we should be using StringUtils.join instead?

> Add support for SSL context and alternate endpoints for PutS3 
> --------------------------------------------------------------
>
>                 Key: NIFI-1225
>                 URL: https://issues.apache.org/jira/browse/NIFI-1225
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Tony Kurc
>            Assignee: Tony Kurc
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: NIFI-1225.000.patch, NIFI-1225.001.patch, 
> NIFI-1225.002.patch, S3_Put_Fetch_Delete.xml
>
>
> NIFI-1107 added this as well as multipart puts, but is not ready. Going to 
> split out the code for SSL context and alternate endpoint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to